[GitHub] [incubator-superset] mistercrunch opened a new pull request #7231: [WiP] fix control validation handling and related state / queries

[GitBox <gi...@apache.org>]

mistercrunch opened a new pull request #7231: [WiP] fix control validation handling and related state / queries
URL: https://github.com/apache/incubator-superset/pull/7231
 
 
   Fixes a series of unexpected, really bad behaviors around control validation:
   
   * when a chart opens in a state where a control is invalid, it still
     runs the query, and sometimes gets stuck in what appears to be a 'running'
     state. After this change, no query is run, and a warning is displayed
     in the chart panel body, just like any other error would
   * validation used to be done in the <Control> component and alter the
     redux store as it went. Clearly this is not the right approach, now
     validation occurs on loading the initial redux state, as well as in
     the reducer when controls are changed
   * currently, when going from a invalid control state to a valid one
     (user addresses what is needed), it auto-triggers a query which can be
     unexpected. After this change, the error message disappears, and the
     "Run Query" overlay gets displayed
   * when changing viz type, it's common to get new validation
     errors, and currently when that occurs it will still go ahead and run
     a query with invalid inputs, which often results in errors
     that are not well handled, since much of the logic
     assumes control-validated input.
   * prettier control validation messages
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org