[jira] [Commented] (HDFS-2117) DiskChecker#mkdirsWithExistsAndPermissionCheck may return true even when the dir is not created

["Suresh Srinivas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072043#comment-13072043 ] 

Suresh Srinivas commented on HDFS-2117:
---------------------------------------

Continuing my previous comment, should not return boolean at all from the method?

> DiskChecker#mkdirsWithExistsAndPermissionCheck may return true even when the dir is not created
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-2117
>                 URL: https://issues.apache.org/jira/browse/HDFS-2117
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.20.203.1
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.20.205.0
>
>         Attachments: hdfs-2117-1.patch
>
>
> In branch-0.20-security as part of HADOOP-6566, DiskChecker#mkdirsWithExistsAndPermissionCheck will return true even if it wasn't able to create the directory, which means instead of throwing a DiskErrorException the code will proceed to getFileStatus and throw a FNF exception. Post HADOOP-7040, which modified makeInstance to catch not just DiskErrorExceptions but IOExceptions as well, this is not an issue since now the exception is caught either way. But for future modifications we should still modify this method to return false if it was unable to create the directory. This code is totally different in trunk, so not an issue there.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira