[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8345: [dashboard] show less filter indicators

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8345: [dashboard] show less filter indicators
URL: https://github.com/apache/incubator-superset/pull/8345#discussion_r332164959
 
 

 ##########
 File path: superset/assets/src/dashboard/components/FilterIndicatorsContainer.jsx
 ##########
 @@ -150,21 +150,16 @@ export default class FilterIndicatorsContainer extends React.PureComponent {
     }
 
     const indicators = this.getFilterIndicators();
-    // if total indicators <= 5, show all
-    // else: show top 4 indicators, and show all the rest in group
+    // if total indicators <= FILTER_INDICATORS_DISPLAY_LENGTH,
+    // show indicator for each filter field.
+    // else: show single group indicator.
     const showExtraIndicatorsInGroup =
 
 Review comment:
   rename to `showIndicatorsInGroup` since we're showing all of them there, not just the extra ones

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org