You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/04/02 01:19:38 UTC

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #475: PHOENIX-5101 ScanningResultIterator getScanMetrics throws NPE

ChinmaySKulkarni commented on a change in pull request #475: PHOENIX-5101 ScanningResultIterator getScanMetrics throws NPE
URL: https://github.com/apache/phoenix/pull/475#discussion_r271104913
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/ScanningResultIterator.java
 ##########
 @@ -122,8 +111,7 @@ private void getScanMetrics() {
             changeMetric(scanMetricsHolder.getCountOfRowsFiltered(),
                     scanMetricsMap.get(COUNT_OF_ROWS_FILTERED_KEY_METRIC_NAME));
 
-            GLOBAL_SCAN_BYTES.update(scanMetricsMap.get(GLOBAL_BYTES_IN_RESULTS_METRIC_NAME));
-
+            GLOBAL_SCAN_BYTES.update(scanMetricsMap.get(BYTES_IN_RESULTS_METRIC_NAME));
 
 Review comment:
   We should also check that the return of the `get` is not null before passing it to `update`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services