You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/08/21 22:40:43 UTC
[GitHub] [hive] jsoref opened a new pull request, #3540: HIVE-26489: Use check-spelling/check-spelling@v0.0.20
jsoref opened a new pull request, #3540:
URL: https://github.com/apache/hive/pull/3540
### What changes were proposed in this pull request?
* Refreshes the workflow based on
https://github.com/check-spelling/spell-check-this/blob/744c66e2140fd8acaf5388efd0db3727d010d6e9/.github/workflows/spelling.yml
* Upgrades the action from v0.0.20-alpha3 to v0.0.20
* I'm excluded the `serde/pom.xml` file as in v0.0.20 it's flagged for a lot of items -- https://github.com/check-spelling/hive/commit/e2674ef68eb5067875a4c9bda6d422a1300c27a7#commitcomment-81785338 -- and it didn't seem worth adding the items, if that isn't the desired state, the file can be removed from `excludes.txt` and `expect.txt` can be updated per the instructions from check-spelling.
### Why are the changes needed?
Alpha releases were for interim development, some changes were made to how the action+workflow interact. Alpha releases are not intended to be supported indefinitely. I will probably disable the `v0.0.20-alpha*` releases at some point (people can still use them if they wish, but this is not recommended)
### Does this PR introduce _any_ user-facing change?
1. The failure seen here:
https://github.com/apache/hive/actions/runs/2758523671
should no longer happen. The refreshed workflow will handle this differently. It may result in an annotation explaining that it's unhappy because there's a merge conflict.
2. The most recent PR comment from check-spelling should be collapsed as new runs occur for the PR.
### How was this patch tested?
The last 4 runs in:
https://github.com/check-spelling/hive/actions
involved basic testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3540: HIVE-26489: Use check-spelling/check-spelling@v0.0.20
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3540:
URL: https://github.com/apache/hive/pull/3540#issuecomment-1221641294
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3540)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3540&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3540&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3540&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3540&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3540&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3540&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3540&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3540&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3540&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3540&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3540&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3540&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3540&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3540&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #3540: HIVE-26489: Use check-spelling/check-spelling@v0.0.20
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3540: HIVE-26489: Use check-spelling/check-spelling@v0.0.20
URL: https://github.com/apache/hive/pull/3540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #3540: HIVE-26489: Use check-spelling/check-spelling@v0.0.20
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3540:
URL: https://github.com/apache/hive/pull/3540#issuecomment-1287555829
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org