[jira] [Commented] (TS-3213) hardcoded log buffer size resulting in flood of warnings in diags.log despite configuring large log buffer size

["Sudheer Vinukonda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231730#comment-14231730 ] 

Sudheer Vinukonda commented on TS-3213:
---------------------------------------

Thanks a lot to [~zwoop] for suggesting the log slicing (TS-2364) to address this issue. TS-2364 looks really cool and helps beyond the current body factory issue (for example, even to trim our squid/custom logs as well). Since, log slicing solves our problem, I will close this jira.

> hardcoded log buffer size resulting in flood of warnings in diags.log despite configuring large log buffer size
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: TS-3213
>                 URL: https://issues.apache.org/jira/browse/TS-3213
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Logging
>    Affects Versions: 5.1.1
>            Reporter: Sudheer Vinukonda
>             Fix For: 5.3.0
>
>
> We have seen a flood of the below warnings in diags.log, despite configuring the log buffer sizes sufficiently large. This happens even when we turned off ascii logging. Upon further investigation, it looks like, the body factory code tries to resolve the body factory templates as custom log entries (since, they may embed custom log fields), but, there's a hard-coded size of 8K for the buffer size that does the log field resolution at {{https://github.com/apache/trafficserver/blob/master/proxy/logging/LogAccess.cc#L1449}}. This makes the configured buffer values useless and results in throwing up the flood of warnings. 
> {code}
> -bash-4.1$ sudo traffic_line -m . | grep log | grep size
> proxy.config.log.log_buffer_size 26624
> proxy.config.log.max_line_size 106496
> proxy.config.log.ascii_buffer_size 106496
> {code}
> {code}
> [Nov 25 23:19:30.343] Server {0x2aeb9b5aa700} NOTE: Traffic Server is skipping the current log entry because its size exceeds the maximum line (entry) size for an ascii log buffer
> {code}
> A simple fix is to use one of the configured log buffer sizes (preferrably, {{proxy.config.log.ascii_buffer_size}}) instead of the hard-coded 8k. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)