You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/07/31 11:13:28 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #42238: Clear some unused codes in "***Errors" and extract some common logic.

LuciferYang commented on code in PR #42238:
URL: https://github.com/apache/spark/pull/42238#discussion_r1279149447


##########
sql/api/src/main/scala/org/apache/spark/sql/errors/DataTypeErrors.scala:
##########
@@ -64,7 +64,7 @@ private[sql] object DataTypeErrors extends DataTypeErrorsBase {
   def unsupportedJavaTypeError(clazz: Class[_]): SparkRuntimeException = {
     new SparkRuntimeException(
       errorClass = "_LEGACY_ERROR_TEMP_2121",
-      messageParameters = Map("clazz" -> clazz.toString()))

Review Comment:
   For these, I prefer not to make any changes, as this may cause unnecessary conflicts during backport
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org