You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/15 01:24:46 UTC

[GitHub] [pulsar] mattisonchao opened a new pull request, #16066: Revert "[fix][broker] Reject auto create partitioned topic when topic name contains ``-partition-`` (#14920)

mattisonchao opened a new pull request, #16066:
URL: https://github.com/apache/pulsar/pull/16066

   These reverts commit #14920 
   
   ### Motivation
   
   Revert this PR because it may affect the DLQ when the user enables `auto-creation` and the creative type is `partitioned`.
   
   ### Modifications
   
   - Revert this PR.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   - [x] `doc-not-needed` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao merged pull request #16066: Revert "[fix][broker] Reject auto create partitioned topic when topic name contains ``-partition-`` (#14920)

Posted by GitBox <gi...@apache.org>.
mattisonchao merged PR #16066:
URL: https://github.com/apache/pulsar/pull/16066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao closed pull request #16066: Revert "[fix][broker] Reject auto create partitioned topic when topic name contains ``-partition-`` (#14920)

Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #16066: Revert "[fix][broker] Reject auto create partitioned topic when topic name contains ``-partition-`` (#14920)
URL: https://github.com/apache/pulsar/pull/16066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao commented on pull request #16066: Revert "[fix][broker] Reject auto create partitioned topic when topic name contains ``-partition-`` (#14920)

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #16066:
URL: https://github.com/apache/pulsar/pull/16066#issuecomment-1155874690

   Because there have some unclear things need to discuss. I will put the list link here when start discussing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] mattisonchao commented on pull request #16066: Revert "[fix][broker] Reject auto create partitioned topic when topic name contains ``-partition-`` (#14920)

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #16066:
URL: https://github.com/apache/pulsar/pull/16066#issuecomment-1155876597

   Also, I have to push a new pull request to add a test that can cover the DLQ of `auto-creation` with the `partitioned` type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org