You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/18 05:45:19 UTC
[GitHub] [airflow] uranusjr opened a new pull request #17676: Mark DAG.param as a decorated field
uranusjr opened a new pull request #17676:
URL: https://github.com/apache/airflow/pull/17676
Fix #17582.
This mainly affects how this field is deserialized; previously it would be deserialized as-is, which is problematic if the param is a nested dict since the inner dicts were serialized with the {"__type": "dict", "__val": ...}` wrapper and not deserialized properly.
I am not at all familiar with the related logic and not sure if I am doing the right thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17676: Mark DAG.param as a decorated field
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17676:
URL: https://github.com/apache/airflow/pull/17676#issuecomment-920782998
No longer needed since #17100 actually implemented a fix (by special-casing `params` on deserialisation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #17676: Mark DAG.param as a decorated field
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #17676:
URL: https://github.com/apache/airflow/pull/17676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #17676: Mark DAG.param as a decorated field
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17676:
URL: https://github.com/apache/airflow/pull/17676#discussion_r691684818
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -651,7 +651,7 @@ class SerializedDAG(DAG, BaseSerialization):
not pickle-able. SerializedDAG works for all DAGs.
"""
- _decorated_fields = {'schedule_interval', 'default_args', '_access_control'}
+ _decorated_fields = {'schedule_interval', 'default_args', 'params', '_access_control'}
Review comment:
Can you add a test in https://github.com/apache/airflow/blob/79c1a0e3a248a379a5d5338fe41675104a241595/tests/serialization/test_dag_serialization.py#L556-L601 please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org