You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/27 06:15:16 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #32355: [SPARK-35221][SQL] Add join hint build side check

cloud-fan commented on a change in pull request #32355:
URL: https://github.com/apache/spark/pull/32355#discussion_r620895895



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HintErrorLogger.scala
##########
@@ -42,6 +45,17 @@ object HintErrorLogger extends HintErrorHandler with Logging {
     logWarning(s"A join hint $hint is specified but it is not part of a join relation.")
   }
 
+  override def joinBuildSideNotSupported(joinType: JoinType, joinHint: JoinHint): Unit = {

Review comment:
       cc @maryannxue 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org