You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Tang <yo...@outlook.com> on 2016/04/04 03:59:08 UTC
Review Request 45664: Replace `EQ(true/false` with `_TRUE/_FALSE` in
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45664/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Bugs: MESOS-4112
https://issues.apache.org/jira/browse/MESOS-4112
Repository: mesos
Description
-------
This patch is a follow up to MESOS-4112 to replace:
1. AWAIT_EQ(true/false to AWAIT_TRUE/FALSE
2. AWAIT_ASSERT_EQ(true/false to AWAIT_ASSERT_TRUE/_FALSE
3. EXPECT_SOME_EQ(true/false to EXPECT_SOME_TRUE/_FALSE
4. EXPECT_EQ(true/false to EXPECT_TRUE/_FALSE
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp b9c26b92c44e8ca718a5eb333855199bdf2a8e81
src/tests/cram_md5_authentication_tests.cpp 67f74e208ce138dc1e4667af108af3538b34aee9
src/tests/gc_tests.cpp 89a7f735b27b7a836b4ce3af10f26a6d63887279
src/tests/group_tests.cpp acfb1485f655f3bc39ee68448ba041af366f70f5
src/tests/health_check_tests.cpp eace7c35f7240dbdc1bd9dd0a44c2d72127bfa70
src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853
src/tests/registrar_tests.cpp f8e141bfc0023128f40ca8ecdae7a5609818c2b1
Diff: https://reviews.apache.org/r/45664/diff/
Testing
-------
make check (Ubuntu 14.04)
Thanks,
Yong Tang
Re: Review Request 45664: Replace `EQ(true/false` with `_TRUE/_FALSE`
in tests.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45664/#review126782
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On April 4, 2016, 1:59 a.m., Yong Tang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45664/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 1:59 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-4112
> https://issues.apache.org/jira/browse/MESOS-4112
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch is a follow up to MESOS-4112 to replace:
> 1. AWAIT_EQ(true/false to AWAIT_TRUE/FALSE
> 2. AWAIT_ASSERT_EQ(true/false to AWAIT_ASSERT_TRUE/_FALSE
> 3. EXPECT_SOME_EQ(true/false to EXPECT_SOME_TRUE/_FALSE
> 4. EXPECT_EQ(true/false to EXPECT_TRUE/_FALSE
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp b9c26b92c44e8ca718a5eb333855199bdf2a8e81
> src/tests/cram_md5_authentication_tests.cpp 67f74e208ce138dc1e4667af108af3538b34aee9
> src/tests/gc_tests.cpp 89a7f735b27b7a836b4ce3af10f26a6d63887279
> src/tests/group_tests.cpp acfb1485f655f3bc39ee68448ba041af366f70f5
> src/tests/health_check_tests.cpp eace7c35f7240dbdc1bd9dd0a44c2d72127bfa70
> src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853
> src/tests/registrar_tests.cpp f8e141bfc0023128f40ca8ecdae7a5609818c2b1
>
> Diff: https://reviews.apache.org/r/45664/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu 14.04)
>
>
> Thanks,
>
> Yong Tang
>
>