[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11090: refactor: Replace react-bootstrap tabs with Antd tabs

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #11090:
URL: https://github.com/apache/incubator-superset/pull/11090#discussion_r498253905



##########
File path: superset-frontend/src/common/components/Tabs.tsx
##########
@@ -16,27 +16,53 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+import React from 'react';
 import { styled } from '@superset-ui/core';
 import { Tabs as AntdTabs } from 'src/common/components';
+import { css } from '@emotion/core';
+import Icon from '../../components/Icon';
 
-const StyledTabs = styled(AntdTabs)`
-  margin-top: -18px;
+interface TabsProps {
+  inModal?: boolean;
+  fullWidth?: boolean;
+}
 
-  .ant-tabs-nav-list {
-    width: 100%;
-  }
+const notForwardedProps = ['fullWidth', 'inModal'];
+
+const StyledTabs = styled(AntdTabs, {
+  shouldForwardProp: prop => !notForwardedProps.includes(prop),
+})<TabsProps>`
+  ${props =>
+    props.inModal &&

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org