You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/26 09:52:14 UTC

[GitHub] WangGuangxin commented on a change in pull request #23460: [SPARK-26544][SQL] Escape string to keep alignment with hive

WangGuangxin commented on a change in pull request #23460: [SPARK-26544][SQL] Escape string to keep alignment with hive
URL: https://github.com/apache/spark/pull/23460#discussion_r260204107
 
 

 ##########
 File path: sql/core/pom.xml
 ##########
 @@ -151,6 +151,10 @@
       <artifactId>mockito-core</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>${hive.group}</groupId>
+      <artifactId>hive-exec</artifactId>
+    </dependency>
 
 Review comment:
   I removed `hive-exec` dependency here. So I think it should be ok don't move `HiveResult` to `hive` module. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org