[GitHub] [spark] huaxingao commented on a diff in pull request #40206: [SPARK-42611][SQL] Insert char/varchar length checks for inner fields during resolution

["huaxingao (via GitHub)" <gi...@apache.org>]

huaxingao commented on code in PR #40206:
URL: https://github.com/apache/spark/pull/40206#discussion_r1120925546


##########
sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala:
##########
@@ -926,4 +926,56 @@ class DSV2CharVarcharTestSuite extends CharVarcharTestSuite
       }
     }
   }
+
+  test("SPARK-42611: check char/varchar length in reordered nested structs") {
+    Seq("CHAR(5)", "VARCHAR(5)").foreach { typ =>
+      withTable("t") {
+        sql(s"CREATE TABLE t(s STRUCT<n_c:$typ,n_i:INT>) USING $format")

Review Comment:
   extremely nit: shall we have an empty space in between of `n_c:$typ,` and `n_i:INT` in this line and also in the `CREATE TABLE` statements below?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org