[GitHub] otaviojava commented on a change in pull request #426: Simple code refactoring. Trying to gain familiarity with the project

[GitBox <gi...@apache.org>]

otaviojava commented on a change in pull request #426: Simple code refactoring. Trying to gain familiarity with the project
URL: https://github.com/apache/tomee/pull/426#discussion_r261179831
 
 

 ##########
 File path: utils/openejb-provisionning/src/main/java/org/apache/openejb/resolver/Resolver.java
 ##########
 @@ -27,14 +27,16 @@
 public class Resolver extends MavenResolver {
     public InputStream resolve(final String rawLocation) {
         final boolean initialized = SystemInstance.isInitialized();
+	final String MVN_JNDI_PREFIX = "mvn:";
 
 Review comment:
   @ShermanMarshall @ShermanMarshall 
   That is a variable name and not a constant, therefore: have to match regular expression '^[a-z][a-zA-Z0-9]*$'
   I belive:
   `final String mvnJNDIPrefix = "mvn:";`
   Sounds better.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services