Re: svn commit: r1072230 - /lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/apache/solr/handler/dataimport/TestTikaEntityProcessor.java

[Robert Muir <rc...@gmail.com>]

On Fri, Feb 18, 2011 at 8:33 PM,  <ho...@apache.org> wrote:
> Author: hossman
> Date: Sat Feb 19 01:33:12 2011
> New Revision: 1072230
>
> URL: http://svn.apache.org/viewvc?rev=1072230&view=rev
> Log:
> this test was missing @Test, and wasn't actually checking any fields were added
>

fyi, the problem was only the latter part, @Test is not required by
the test system if the test method starts with "test" (see
LuceneTestCaseRunner for details)

all of our junit tests are actually run as junit 4 tests, but we don't
require the useless @Test, @Before, and @After (just use test*,
setUp(), tearDown() as usual).
You can use @BeforeClass though.

this way we get the benefits of junit 4, without the hassles.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: svn commit: r1072230 - /lucene/dev/trunk/solr/contrib/dataimporthandler/src/extras/test/java/org/ apache/solr/handler/dataimport/TestTikaEntityProcessor.java

[Chris Hostetter <ho...@fucit.org>]

: fyi, the problem was only the latter part, @Test is not required by
: the test system if the test method starts with "test" (see
: LuceneTestCaseRunner for details)

Ah ... ok ... my mistake, i didn't see the Test listed in the 
console output and assumed it was because of hte missing @Test -- but i 
think i was just looking in the wrong place (i was also confused by the 
whole "extras" thing so i was probably only running hte main DIH tests at 
that time)


-Hoss

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org