You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/08/07 12:43:16 UTC
Review Request 13373: keep the existing changes in cloud-set-guest-sshkey.in
to make sure we do not break the backward compatibility.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13373/
-----------------------------------------------------------
Review request for cloudstack and Jayapal Reddy.
Bugs: Cloudstack-4138
Repository: cloudstack-git
Description
-------
keep the existing changes in cloud-set-guest-sshkey.in to make sure we do not break the backward compatibility.
Diffs
-----
setup/bindir/cloud-set-guest-sshkey.in 9436b03
Diff: https://reviews.apache.org/r/13373/diff/
Testing
-------
Tested on 4.2
Thanks,
bharat kumar
Re: Review Request 13373: keep the existing changes in
cloud-set-guest-sshkey.in to make sure we do not break the backward
compatibility.
Posted by Sheng Yang <sh...@yasker.org>.
> On Aug. 8, 2013, 5:40 p.m., Sheng Yang wrote:
> > Ship It!
Pushed to 4.2 and MASTER.
- Sheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13373/#review24896
-----------------------------------------------------------
On Aug. 7, 2013, 1:25 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13373/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 1:25 p.m.)
>
>
> Review request for cloudstack, Jayapal Reddy and Sheng Yang.
>
>
> Bugs: Cloudstack-4138
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> keep the existing changes in cloud-set-guest-sshkey.in to make sure we do not break the backward compatibility.
>
>
> Diffs
> -----
>
> setup/bindir/cloud-set-guest-sshkey.in 9436b03
>
> Diff: https://reviews.apache.org/r/13373/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13373: keep the existing changes in
cloud-set-guest-sshkey.in to make sure we do not break the backward
compatibility.
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13373/#review24896
-----------------------------------------------------------
Ship it!
Ship It!
- Sheng Yang
On Aug. 7, 2013, 1:25 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13373/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 1:25 p.m.)
>
>
> Review request for cloudstack, Jayapal Reddy and Sheng Yang.
>
>
> Bugs: Cloudstack-4138
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> keep the existing changes in cloud-set-guest-sshkey.in to make sure we do not break the backward compatibility.
>
>
> Diffs
> -----
>
> setup/bindir/cloud-set-guest-sshkey.in 9436b03
>
> Diff: https://reviews.apache.org/r/13373/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13373: keep the existing changes in
cloud-set-guest-sshkey.in to make sure we do not break the backward
compatibility.
Posted by bharat kumar <bh...@citrix.com>.
> On Aug. 7, 2013, 10:43 p.m., Sheng Yang wrote:
> > Look fine to me.
> >
> > Make sure when you test it, you tested both way(with data-center or not).
>
> bharat kumar wrote:
> Tested both the code paths ie with data-center and without datacenter.
sorry with data-server and without data-server
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13373/#review24838
-----------------------------------------------------------
On Aug. 7, 2013, 1:25 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13373/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 1:25 p.m.)
>
>
> Review request for cloudstack, Jayapal Reddy and Sheng Yang.
>
>
> Bugs: Cloudstack-4138
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> keep the existing changes in cloud-set-guest-sshkey.in to make sure we do not break the backward compatibility.
>
>
> Diffs
> -----
>
> setup/bindir/cloud-set-guest-sshkey.in 9436b03
>
> Diff: https://reviews.apache.org/r/13373/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13373: keep the existing changes in
cloud-set-guest-sshkey.in to make sure we do not break the backward
compatibility.
Posted by bharat kumar <bh...@citrix.com>.
> On Aug. 7, 2013, 10:43 p.m., Sheng Yang wrote:
> > Look fine to me.
> >
> > Make sure when you test it, you tested both way(with data-center or not).
Tested both the code paths ie with data-center and without datacenter.
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13373/#review24838
-----------------------------------------------------------
On Aug. 7, 2013, 1:25 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13373/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 1:25 p.m.)
>
>
> Review request for cloudstack, Jayapal Reddy and Sheng Yang.
>
>
> Bugs: Cloudstack-4138
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> keep the existing changes in cloud-set-guest-sshkey.in to make sure we do not break the backward compatibility.
>
>
> Diffs
> -----
>
> setup/bindir/cloud-set-guest-sshkey.in 9436b03
>
> Diff: https://reviews.apache.org/r/13373/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13373: keep the existing changes in
cloud-set-guest-sshkey.in to make sure we do not break the backward
compatibility.
Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13373/#review24838
-----------------------------------------------------------
Look fine to me.
Make sure when you test it, you tested both way(with data-center or not).
- Sheng Yang
On Aug. 7, 2013, 1:25 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13373/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 1:25 p.m.)
>
>
> Review request for cloudstack, Jayapal Reddy and Sheng Yang.
>
>
> Bugs: Cloudstack-4138
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> keep the existing changes in cloud-set-guest-sshkey.in to make sure we do not break the backward compatibility.
>
>
> Diffs
> -----
>
> setup/bindir/cloud-set-guest-sshkey.in 9436b03
>
> Diff: https://reviews.apache.org/r/13373/diff/
>
>
> Testing
> -------
>
> Tested on 4.2
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 13373: keep the existing changes in
cloud-set-guest-sshkey.in to make sure we do not break the backward
compatibility.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13373/
-----------------------------------------------------------
(Updated Aug. 7, 2013, 1:25 p.m.)
Review request for cloudstack, Jayapal Reddy and Sheng Yang.
Bugs: Cloudstack-4138
Repository: cloudstack-git
Description
-------
keep the existing changes in cloud-set-guest-sshkey.in to make sure we do not break the backward compatibility.
Diffs
-----
setup/bindir/cloud-set-guest-sshkey.in 9436b03
Diff: https://reviews.apache.org/r/13373/diff/
Testing
-------
Tested on 4.2
Thanks,
bharat kumar