[GitHub] [hadoop] 9uapaw commented on a change in pull request #4060: YARN-11084. Introduce new config to specify AM default node-label whe…

[GitBox <gi...@apache.org>]

9uapaw commented on a change in pull request #4060:
URL: https://github.com/apache/hadoop/pull/4060#discussion_r825640757



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAppManager.java
##########
@@ -640,6 +643,12 @@ private RMAppImpl createAndPopulateNewRMApp(
           SchedulerUtils.normalizeAndValidateRequest(amReq, maxAllocation,
               queue, isRecovery, rmContext, null, nodeLabelsEnabled);
 
+          String amNodeLabel = amReq.getNodeLabelExpression();
+          if (org.apache.commons.lang3.StringUtils.isEmpty(amNodeLabel)

Review comment:
       Please use a simpler package identifier ie. Stringutils.isEmpty, or import isEmpty directly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org