You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/27 16:40:37 UTC

[GitHub] [incubator-superset] lilykuang opened a new pull request #11446: feat: annotations list CRUD view

lilykuang opened a new pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - Annotation List CRUD view 
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   ![Screen Shot 2020-10-27 at 9 39 43 AM](https://user-images.githubusercontent.com/5705598/97333090-649a4880-1838-11eb-82b9-7f768a99ea22.png)
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   WIP
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on pull request #11446: feat: annotations list CRUD view

Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446#issuecomment-717722838


   A rebase _should_ fix the broken E2E test (see #11453)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11446: feat: annotations list CRUD view

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446#issuecomment-717544242


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=h1) Report
   > Merging [#11446](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88e5e9855db2bb64ffd20d6749ccd940d7d04d01?el=desc) will **decrease** coverage by `5.68%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11446/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11446      +/-   ##
   ==========================================
   - Coverage   66.58%   60.90%   -5.69%     
   ==========================================
     Files         863      417     -446     
     Lines       40985    25960   -15025     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        27290    15810   -11480     
   + Misses      13598    10150    -3448     
   + Partials       97        0      -97     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.90% <75.00%> (-1.00%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <ø> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <75.00%> (-1.49%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.88%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | ... and [462 more](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=footer). Last update [88e5e98...1ec13cd](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett commented on pull request #11446: feat: annotations list CRUD view

Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446#issuecomment-718101517


   @riahk would you mind giving this a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11446: feat: annotations list CRUD view

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446#discussion_r512853328



##########
File path: superset/annotation_layers/annotations/api.py
##########
@@ -99,12 +100,13 @@ class AnnotationRestApi(BaseSupersetModelRestApi):
     edit_model_schema = AnnotationPutSchema()
     edit_columns = add_columns
     order_columns = [
-        "short_descr",
-        "created_by.first_name",
         "changed_by.first_name",
         "changed_on_delta_humanized",
-        "start_dttm",
+        "created_by.first_name",
         "end_dttm",
+        "long_descr",
+        "short_descr",
+        "start_dttm",

Review comment:
       cool! thank you




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #11446: feat: annotations list CRUD view

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446#issuecomment-717544242


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=h1) Report
   > Merging [#11446](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/155b5edec131d71eb392ee52f9bf97de495c2ef0?el=desc) will **decrease** coverage by `1.16%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11446/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11446      +/-   ##
   ==========================================
   - Coverage   62.23%   61.07%   -1.17%     
   ==========================================
     Files         863      417     -446     
     Lines       40983    25961   -15022     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25506    15855    -9651     
   + Misses      15298    10106    -5192     
   + Partials      179        0     -179     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.07% <75.00%> (-0.79%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <ø> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <75.00%> (-1.49%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.00% <0.00%> (-7.47%)` | :arrow_down: |
   | [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
   | ... and [462 more](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=footer). Last update [155b5ed...763a035](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11446: feat: annotations list CRUD view

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446#issuecomment-717544242


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=h1) Report
   > Merging [#11446](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/155b5edec131d71eb392ee52f9bf97de495c2ef0?el=desc) will **decrease** coverage by `1.17%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11446/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11446      +/-   ##
   ==========================================
   - Coverage   62.23%   61.05%   -1.18%     
   ==========================================
     Files         863      417     -446     
     Lines       40983    25972   -15011     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25506    15858    -9648     
   + Misses      15298    10114    -5184     
   + Partials      179        0     -179     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.05% <75.00%> (-0.81%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <ø> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <75.00%> (-1.49%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.64%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.00% <0.00%> (-7.47%)` | :arrow_down: |
   | [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
   | ... and [458 more](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=footer). Last update [155b5ed...763a035](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] willbarrett merged pull request #11446: feat: annotations list CRUD view

Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11446: feat: annotations list CRUD view

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446#issuecomment-717544242


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=h1) Report
   > Merging [#11446](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/155b5edec131d71eb392ee52f9bf97de495c2ef0?el=desc) will **decrease** coverage by `0.65%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11446/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11446      +/-   ##
   ==========================================
   - Coverage   62.23%   61.57%   -0.66%     
   ==========================================
     Files         863      417     -446     
     Lines       40983    25972   -15011     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25506    15993    -9513     
   + Misses      15298     9979    -5319     
   + Partials      179        0     -179     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.57% <75.00%> (-0.29%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <ø> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <75.00%> (-1.49%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.38% <0.00%> (-3.36%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.73% <0.00%> (-2.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
   | ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=footer). Last update [155b5ed...763a035](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11446: feat: annotations list CRUD view

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11446:
URL: https://github.com/apache/incubator-superset/pull/11446#issuecomment-717544242


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=h1) Report
   > Merging [#11446](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/155b5edec131d71eb392ee52f9bf97de495c2ef0?el=desc) will **decrease** coverage by `0.66%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11446/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11446      +/-   ##
   ==========================================
   - Coverage   62.23%   61.56%   -0.67%     
   ==========================================
     Files         863      417     -446     
     Lines       40983    25972   -15011     
     Branches     3694        0    -3694     
   ==========================================
   - Hits        25506    15990    -9516     
   + Misses      15298     9982    -5316     
   + Partials      179        0     -179     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `?` | |
   | #python | `61.56% <75.00%> (-0.30%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.84% <ø> (ø)` | |
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.18% <ø> (ø)` | |
   | [superset/views/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | `78.94% <75.00%> (-1.49%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.38% <0.00%> (-3.36%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.73% <0.00%> (-2.84%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
   | ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11446/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=footer). Last update [155b5ed...763a035](https://codecov.io/gh/apache/incubator-superset/pull/11446?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org