You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by bu...@apache.org on 2006/02/26 13:46:18 UTC
DO NOT REPLY [Bug 38785] New: - strange looking equals
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38785>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38785
Summary: strange looking equals
Product: Batik
Version: 1.6
Platform: All
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: CSS
AssignedTo: batik-dev@xmlgraphics.apache.org
ReportedBy: dvholten@computer.org
in batik.css.engine.sac.AbstractElementSelector i found an equals-method like this:
public boolean equals( Object obj ) {
if ( obj == null || !( obj.getClass() != getClass() )) {
return false;
}
... other comparisons ...
The double negated class-compare doesnt make sense to me. The intention seems to
be to reject checks against other classes. I 'd do it with instanceof.
The same code exists in AbstractAttributeCondition, AbstractCombinatorCondition,
AbstractDescendantSelector, AbstractSiblingSelector, CSSConditionalSelector,
CSSLangCondition.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 38785] - strange looking equals
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38785>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38785
deweese@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From deweese@apache.org 2006-03-05 03:54 -------
Fixed in SVN
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org