You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/05/22 15:26:19 UTC
Review Request 21807: Decouple ClusterEntity, StateEntity, RequestEntity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21807/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-5857
https://issues.apache.org/jira/browse/AMBARI-5857
Repository: ambari
Description
-------
* Decouple ClusterEntity, StateEntity, RequestEntity to prepare for non-cluster based actions.
* @Ignore'd an unrelated test that fails with a PermGen error (it was annoying me, and we already have a filed JIRA for it).
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 2104bd6
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java b253138
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java b3b5279
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java fcb3d66
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java cd78722
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java f80ac7d
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java 2a353b4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 388ce3a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0f43490
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 62af506
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql d1f5a6d
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 59b14c1
ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 7729874
ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java f322bfb
Diff: https://reviews.apache.org/r/21807/diff/
Testing
-------
* Manual verification that deploying/stop/start did not change
* Unit tests:
Results :
Tests run: 1609, Failures: 0, Errors: 0, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:03.061s
[INFO] Finished at: Thu May 22 09:25:11 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 21807: Decouple ClusterEntity, StateEntity, RequestEntity
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21807/#review43716
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On May 22, 2014, 2:24 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21807/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 2:24 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5857
> https://issues.apache.org/jira/browse/AMBARI-5857
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Decouple ClusterEntity, StateEntity, RequestEntity to prepare for non-cluster based actions.
> * @Ignore'd an unrelated test that fails with a PermGen error (it was annoying me, and we already have a filed JIRA for it).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 2104bd6
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java b253138
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java b3b5279
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java fcb3d66
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java cd78722
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java f80ac7d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java 2a353b4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 388ce3a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0f43490
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 62af506
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql d1f5a6d
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 59b14c1
> ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 7729874
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java f322bfb
>
> Diff: https://reviews.apache.org/r/21807/diff/
>
>
> Testing
> -------
>
> * Manual verification that deploying/stop/start did not change
> * Unit tests:
>
> Results :
>
> Tests run: 1609, Failures: 0, Errors: 0, Skipped: 13
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:03.061s
> [INFO] Finished at: Thu May 22 09:25:11 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 21807: Decouple ClusterEntity, StateEntity, RequestEntity
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21807/
-----------------------------------------------------------
(Updated May 22, 2014, 10:24 a.m.)
Review request for Ambari, Sid Wagle and Tom Beerbower.
Changes
-------
Updated patch from Tom's review
Bugs: AMBARI-5857
https://issues.apache.org/jira/browse/AMBARI-5857
Repository: ambari
Description
-------
* Decouple ClusterEntity, StateEntity, RequestEntity to prepare for non-cluster based actions.
* @Ignore'd an unrelated test that fails with a PermGen error (it was annoying me, and we already have a filed JIRA for it).
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 2104bd6
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java b253138
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java b3b5279
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java fcb3d66
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java cd78722
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java f80ac7d
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java 2a353b4
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 388ce3a
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0f43490
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 62af506
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql d1f5a6d
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 59b14c1
ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 7729874
ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java f322bfb
Diff: https://reviews.apache.org/r/21807/diff/
Testing
-------
* Manual verification that deploying/stop/start did not change
* Unit tests:
Results :
Tests run: 1609, Failures: 0, Errors: 0, Skipped: 13
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:03.061s
[INFO] Finished at: Thu May 22 09:25:11 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 21807: Decouple ClusterEntity, StateEntity, RequestEntity
Posted by Nate Cole <nc...@hortonworks.com>.
> On May 22, 2014, 9:49 a.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java, lines 96-100
> > <https://reviews.apache.org/r/21807/diff/1/?file=587984#file587984line96>
> >
> > I guess the empty catch is intentional? Is this the case where the cluster id == -1? If so, would it be better to check the value of the id first?
Thanks for reviewing Tom! Yes, this should be a check for -1, and throw a RuntimeException (as we do in other places) if the cluster cannot be loaded by the id.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21807/#review43711
-----------------------------------------------------------
On May 22, 2014, 9:26 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21807/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 9:26 a.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5857
> https://issues.apache.org/jira/browse/AMBARI-5857
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Decouple ClusterEntity, StateEntity, RequestEntity to prepare for non-cluster based actions.
> * @Ignore'd an unrelated test that fails with a PermGen error (it was annoying me, and we already have a filed JIRA for it).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 2104bd6
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java b253138
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java b3b5279
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java fcb3d66
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java cd78722
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java f80ac7d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java 2a353b4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 388ce3a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0f43490
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 62af506
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql d1f5a6d
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 59b14c1
> ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 7729874
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java f322bfb
>
> Diff: https://reviews.apache.org/r/21807/diff/
>
>
> Testing
> -------
>
> * Manual verification that deploying/stop/start did not change
> * Unit tests:
>
> Results :
>
> Tests run: 1609, Failures: 0, Errors: 0, Skipped: 13
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:03.061s
> [INFO] Finished at: Thu May 22 09:25:11 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 21807: Decouple ClusterEntity, StateEntity, RequestEntity
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21807/#review43711
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java
<https://reviews.apache.org/r/21807/#comment78001>
I guess the empty catch is intentional? Is this the case where the cluster id == -1? If so, would it be better to check the value of the id first?
- Tom Beerbower
On May 22, 2014, 1:26 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21807/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 1:26 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-5857
> https://issues.apache.org/jira/browse/AMBARI-5857
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Decouple ClusterEntity, StateEntity, RequestEntity to prepare for non-cluster based actions.
> * @Ignore'd an unrelated test that fails with a PermGen error (it was annoying me, and we already have a filed JIRA for it).
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java 2104bd6
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java b253138
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java b3b5279
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java fcb3d66
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java cd78722
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java f80ac7d
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java 2a353b4
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog161.java 388ce3a
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0f43490
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 62af506
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql d1f5a6d
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 59b14c1
> ambari-server/src/test/java/org/apache/ambari/server/orm/TestOrmImpl.java 7729874
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java f322bfb
>
> Diff: https://reviews.apache.org/r/21807/diff/
>
>
> Testing
> -------
>
> * Manual verification that deploying/stop/start did not change
> * Unit tests:
>
> Results :
>
> Tests run: 1609, Failures: 0, Errors: 0, Skipped: 13
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:03.061s
> [INFO] Finished at: Thu May 22 09:25:11 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>