You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by kh...@apache.org on 2017/03/02 19:01:33 UTC
geode git commit: GEODE-2488: Remove lsof from netstat command tests
Repository: geode
Updated Branches:
refs/heads/feature/GEODE-2488 [created] 9e7edbf1c
GEODE-2488: Remove lsof from netstat command tests
Removed the --with-lsof option from netstat command to reduce the
command response size. Avoids OOME's on JVMs in the test environment
with small heaps.
The original tests with lsof have been retained, but annotated with
@Ignore.
Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/9e7edbf1
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/9e7edbf1
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/9e7edbf1
Branch: refs/heads/feature/GEODE-2488
Commit: 9e7edbf1c3e9612b9862671419f36c26b52e43e7
Parents: 635d311
Author: Ken Howe <kh...@pivotal.io>
Authored: Thu Mar 2 09:40:55 2017 -0800
Committer: Ken Howe <kh...@pivotal.io>
Committed: Thu Mar 2 09:40:55 2017 -0800
----------------------------------------------------------------------
.../internal/cli/NetstatDUnitTest.java | 26 +++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/geode/blob/9e7edbf1/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java b/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
index c6248e0..e987fc2 100644
--- a/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
@@ -24,6 +24,7 @@ import org.apache.geode.test.junit.categories.FlakyTest;
import org.junit.After;
import org.junit.BeforeClass;
import org.junit.ClassRule;
+import org.junit.Ignore;
import org.junit.Test;
import org.junit.experimental.categories.Category;
@@ -40,6 +41,7 @@ public class NetstatDUnitTest {
private static int[] ports = AvailablePortHelper.getRandomAvailableTCPPorts(3);
private static String netStatCommand = null;
+ private static String netStatLsofCommand = null;
@BeforeClass
public static void beforeClass() throws Exception {
@@ -67,7 +69,8 @@ public class NetstatDUnitTest {
// start another server
lsRule.startServerVM(3, properties);
- netStatCommand = "netstat --with-lsof=true --member=" + server.getName();
+ netStatCommand = "netstat --with-lsof=false --member=" + server.getName();
+ netStatLsofCommand = "netstat --with-lsof=true --member=" + server.getName();
}
@Test
@@ -88,6 +91,27 @@ public class NetstatDUnitTest {
gfshConnector.executeAndVerifyCommand(netStatCommand);
}
+ @Ignore
+ @Test
+ public void testConnectToLocatorWithLargeCommandResponse() throws Exception {
+ gfshConnector.connect(ports[0], GfshShellConnectionRule.PortType.locator);
+ gfshConnector.executeAndVerifyCommand(netStatLsofCommand);
+ }
+
+ @Ignore
+ @Test
+ public void testConnectToJmxManagerOneWithLargeCommandResponse() throws Exception {
+ gfshConnector.connect(ports[1], GfshShellConnectionRule.PortType.jmxManger);
+ gfshConnector.executeAndVerifyCommand(netStatLsofCommand);
+ }
+
+ @Ignore
+ @Test
+ public void testConnectToJmxManagerTwoWithLargeCommandResponse() throws Exception {
+ gfshConnector.connect(ports[2], GfshShellConnectionRule.PortType.jmxManger);
+ gfshConnector.executeAndVerifyCommand(netStatLsofCommand);
+ }
+
@After
public void after() throws Exception {
gfshConnector.disconnect();