You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2019/07/09 13:57:50 UTC

[GitHub] [incubator-pagespeed-mod] oschaaf commented on a change in pull request #1912: adding hiredis library to bazel build

oschaaf commented on a change in pull request #1912: adding hiredis library to bazel build
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1912#discussion_r301595672
 
 

 ##########
 File path: bazel/hiredis.bzl
 ##########
 @@ -0,0 +1,23 @@
+hiredis_build_rule = """
+cc_library(
+    name = "hiredis",
+    srcs = [
+        "async.c",
+        "hiredis.c",
+        "net.c",
+        "read.c",
+        "sds.c",
+    ],
+    hdrs = [
+        "dict.c",
 
 Review comment:
   So first I was wondering: should this be declared in `srcs` instead of `hdrs`?
   But after digging in, I think you made the right choice here. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services