You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/03/15 01:50:15 UTC
[jira] [Commented] (TAP5-2054) `dom.js` implementations break when
minified
[ https://issues.apache.org/jira/browse/TAP5-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602961#comment-13602961 ]
Hudson commented on TAP5-2054:
------------------------------
Integrated in tapestry-trunk-freestyle #1034 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/1034/])
TAP5-2054: dom.coffee code doesn't work if minified (Revision 653a41d6dc2f3831957a15b127477d22021a8af3)
Result = SUCCESS
hlship :
Files :
* tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-jquery.coffee
* tapestry-core/src/main/coffeescript/org/apache/tapestry5/t5-core-dom-prototype.coffee
> `dom.js` implementations break when minified
> --------------------------------------------
>
> Key: TAP5-2054
> URL: https://issues.apache.org/jira/browse/TAP5-2054
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Jochen Kemnade
> Assignee: Howard M. Lewis Ship
> Labels: javascript, jquery, prototype
> Fix For: 5.4
>
>
> When either of the `dom.js` implementations is minified via closure compiler, its "inner" classes are renamed and the `convertContent` function breaks for `ElementWrapper` instances. as `constructor?.name` is not "ElementWrapper" anymore.
> If a module's classes should be globally available, they should be exported, otherwise the `instanceof` operator might be a better choice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira