You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/03/07 19:25:22 UTC
[GitHub] zeppelin pull request #2109: [ZEPPELIN-2231] Helium bundle should be able to...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2109
[ZEPPELIN-2231] Helium bundle should be able to import JSON
### What is this PR for?
Helium bundle should be able to import JSON to use some libraries which require JSON. For example, [markdown-it](https://github.com/markdown-it/markdown-it)
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2231](https://issues.apache.org/jira/browse/ZEPPELIN-2231)
### How should this be tested?
1. Clone https://github.com/1ambda/zeppelin-markdown-spell
2. Copy `zeppelin-markdown-spell.json` into `$ZEPPELIN_HOME/helium`
3. Modify artifact (= file path) in `zeppelin-markdown-spell.json` properly
4. Install it in `localhost:9000/#helium`
5. Test `%markdown` spell with
```
%markdown
# h1 Heading 8-)
## Horizontal Rules
___
## Tables
Right aligned columns
| Option | Description |
| ------:| -----------:|
| data | path to data files to supply the data that will be passed into templates. |
| engine | engine to be used for processing templates. Handlebars is the default. |
| ext | extension to be used for dest files. |
```
### Screenshots (if appropriate)
<img width="829" alt="usage1" src="https://cloud.githubusercontent.com/assets/4968473/23673868/30cf6ef2-03b7-11e7-923a-bf4ea05df186.png">
<img width="831" alt="usage2" src="https://cloud.githubusercontent.com/assets/4968473/23673869/3296d04a-03b7-11e7-9a8b-64ba3fcae5b4.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2231/import-json-in-helium-bundle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2109
----
commit 2156275717d733c38f56ec91a758a0fdc216aa09
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-07T19:20:48Z
feat: Import JSON in helium bundle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2109: [ZEPPELIN-2231] Helium bundle should be able to import...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2109
LGTM and merge to master if no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2109: [ZEPPELIN-2231] Helium bundle should be able to...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2109
[ZEPPELIN-2231] Helium bundle should be able to import JSON
### What is this PR for?
Helium bundle should be able to import JSON to use some libraries which require JSON. For example, [markdown-it](https://github.com/markdown-it/markdown-it)
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2231](https://issues.apache.org/jira/browse/ZEPPELIN-2231)
### How should this be tested?
1. Clone https://github.com/1ambda/zeppelin-markdown-spell
2. Copy `zeppelin-markdown-spell.json` into `$ZEPPELIN_HOME/helium`
3. Modify artifact (= file path) in `zeppelin-markdown-spell.json` properly
4. Install it in `localhost:9000/#helium`
5. Test `%markdown` spell with
```
%markdown
# h1 Heading 8-)
## Horizontal Rules
___
## Tables
Right aligned columns
| Option | Description |
| ------:| -----------:|
| data | path to data files to supply the data that will be passed into templates. |
| engine | engine to be used for processing templates. Handlebars is the default. |
| ext | extension to be used for dest files. |
```
### Screenshots (if appropriate)
<img width="829" alt="usage1" src="https://cloud.githubusercontent.com/assets/4968473/23673868/30cf6ef2-03b7-11e7-923a-bf4ea05df186.png">
<img width="831" alt="usage2" src="https://cloud.githubusercontent.com/assets/4968473/23673869/3296d04a-03b7-11e7-9a8b-64ba3fcae5b4.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2231/import-json-in-helium-bundle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2109
----
commit 2156275717d733c38f56ec91a758a0fdc216aa09
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-07T19:20:48Z
feat: Import JSON in helium bundle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2109: [ZEPPELIN-2231] Helium bundle should be able to...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2109: [ZEPPELIN-2231] Helium bundle should be able to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---