You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/20 17:38:32 UTC

[GitHub] [pulsar] gaoran10 opened a new pull request #11731: [Broker] Remove the subscription when closing Reader

gaoran10 opened a new pull request #11731:
URL: https://github.com/apache/pulsar/pull/11731


   ### Motivation
   
   Currently, the subscription will not be removed when closing the non-persistent topic reader.
   
   ### Modifications
   
   Add a new field `isDurable` in NonPersistentSubscription, if the field is false the non-persistent subscription should be removed when closing the subscription(Such as a Reader subscription), or the subscription will be retained(Such as a Consumer subscription).
   
   ### Verifying this change
   
   Add a new unit test to verify the reader subscription could be removed.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   #### For committer
   
   For this PR, do we need to update docs?
   
   - If no, label this PR with the `no-need-doc` label and explain why.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #11731: [Broker] Remove subscription when closing Reader on non-persistent topics

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #11731:
URL: https://github.com/apache/pulsar/pull/11731


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org