You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by ma...@apache.org on 2023/03/24 18:39:32 UTC

[solr-sandbox] branch crossdc-wip updated: Fix next link in NoOpUpdateRequestProcessor. (#52)

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch crossdc-wip
in repository https://gitbox.apache.org/repos/asf/solr-sandbox.git


The following commit(s) were added to refs/heads/crossdc-wip by this push:
     new ad131ec  Fix next link in NoOpUpdateRequestProcessor. (#52)
ad131ec is described below

commit ad131ec92e558eb8e21a7d0cd29c3aeb09911190
Author: Mark Robert Miller <ma...@apache.org>
AuthorDate: Fri Mar 24 13:39:26 2023 -0500

    Fix next link in NoOpUpdateRequestProcessor. (#52)
---
 .../update/processor/MirroringUpdateRequestProcessorFactory.java  | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/crossdc-producer/src/main/java/org/apache/solr/update/processor/MirroringUpdateRequestProcessorFactory.java b/crossdc-producer/src/main/java/org/apache/solr/update/processor/MirroringUpdateRequestProcessorFactory.java
index 06f7dba..669bfa2 100644
--- a/crossdc-producer/src/main/java/org/apache/solr/update/processor/MirroringUpdateRequestProcessorFactory.java
+++ b/crossdc-producer/src/main/java/org/apache/solr/update/processor/MirroringUpdateRequestProcessorFactory.java
@@ -60,8 +60,6 @@ public class MirroringUpdateRequestProcessorFactory extends UpdateRequestProcess
         implements SolrCoreAware, UpdateRequestProcessorFactory.RunAlways {
 
     private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
-    public static final NoOpUpdateRequestProcessor NO_OP_UPDATE_REQUEST_PROCESSOR =
-        new NoOpUpdateRequestProcessor();
 
     // Flag for mirroring requests
     public static final String SERVER_SHOULD_MIRROR = "shouldMirror";
@@ -210,7 +208,7 @@ public class MirroringUpdateRequestProcessorFactory extends UpdateRequestProcess
                                                 final UpdateRequestProcessor next) {
 
         if (!enabled) {
-            return NO_OP_UPDATE_REQUEST_PROCESSOR;
+            return new NoOpUpdateRequestProcessor(next);
         }
 
         // if the class fails to initialize
@@ -256,8 +254,8 @@ public class MirroringUpdateRequestProcessorFactory extends UpdateRequestProcess
     }
 
     private static class NoOpUpdateRequestProcessor extends UpdateRequestProcessor {
-        NoOpUpdateRequestProcessor() {
-            super(null);
+        NoOpUpdateRequestProcessor(UpdateRequestProcessor next) {
+            super(next);
         }
     }