[GitHub] [incubator-streampark] wuchunfu commented on a diff in pull request #1943: [Improve] Unified Mapper

[GitBox <gi...@apache.org>]

wuchunfu commented on code in PR #1943:
URL: https://github.com/apache/incubator-streampark/pull/1943#discussion_r1011068622


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/service/impl/MenuServiceImpl.java:
##########
@@ -133,7 +133,9 @@ public void updateMenu(Menu menu) throws Exception {
     public void deleteMenus(String[] menuIds) throws Exception {
         for (String menuId : menuIds) {
             // Find users associated with these menus/buttons
-            this.baseMapper.deleteRoleMenuByMenuId(Long.parseLong(menuId));
+            LambdaQueryWrapper<Menu> queryWrapper = new LambdaQueryWrapper<>();
+            queryWrapper.eq(StringUtils.isNotEmpty(menuId), Menu::getMenuId, Long.parseLong(menuId));
+            this.remove(queryWrapper);

Review Comment:
   I was careless, thanks for the reminder, I want to fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org