You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "DaveTeng0 (via GitHub)" <gi...@apache.org> on 2023/05/09 19:36:52 UTC
[GitHub] [ozone] DaveTeng0 opened a new pull request, #4691: HDDS-8549. Restore client-side validation of bucket names
DaveTeng0 opened a new pull request, #4691:
URL: https://github.com/apache/ozone/pull/4691
## What changes were proposed in this pull request?
Restore client-side validation of bucket names
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8549
## How was this patch tested?
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on pull request #4691: HDDS-8549. Restore client-side validation of bucket names
Posted by "DaveTeng0 (via GitHub)" <gi...@apache.org>.
DaveTeng0 commented on PR #4691:
URL: https://github.com/apache/ozone/pull/4691#issuecomment-1540789879
cc. @swagle @umamaheswararao @adoroszlai @jojochuang @kerneltime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #4691: HDDS-8549. Restore client-side validation of bucket names
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #4691:
URL: https://github.com/apache/ozone/pull/4691#issuecomment-1542702519
Looks like Github issue remains, CIs are not actually running: https://www.githubstatus.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl commented on pull request #4691: HDDS-8549. Restore client-side validation of bucket names
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #4691:
URL: https://github.com/apache/ozone/pull/4691#issuecomment-1542884796
CI passed. Merged. Thanks @DaveTeng0 for the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on pull request #4691: HDDS-8549. Restore client-side validation of bucket names
Posted by "DaveTeng0 (via GitHub)" <gi...@apache.org>.
DaveTeng0 commented on PR #4691:
URL: https://github.com/apache/ozone/pull/4691#issuecomment-1542480935
> Thanks @DaveTeng0 for the patch.
>
> There are 5 methods where bucket name was previously validated and is not being restored. You can find these by comparing `RpcClient` to the state prior to your original change [298e7ee](https://github.com/apache/ozone/commit/298e7eee13509f89502c516bc11919ead7b34333):
>
> ```
> git diff 298e7eee13~1.. -- hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
> ```
>
> * `completeMultipartUpload`
> * `abortMultipartUpload`
> * `listParts`
> * `headObject`
> * `setBucketOwner`
oh! you're absolutely right! Somehow I only committed parts of changes.. those missing methods' changes still stays on my local. pushing now! thanks attila!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] smengcl merged pull request #4691: HDDS-8549. Restore client-side validation of bucket names
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl merged PR #4691:
URL: https://github.com/apache/ozone/pull/4691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org