[jira] [Updated] (CXF-6845) Some methods in MessageUtils prone to NPE

["Francesco Chicchiriccò (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CXF-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Chicchiriccò updated CXF-6845:
----------------------------------------
    Attachment: CXF-6845.diff

Being this a core class, I prefer to attach a patch instead of committing the fix directly; please review.

> Some methods in MessageUtils prone to NPE
> -----------------------------------------
>
>                 Key: CXF-6845
>                 URL: https://issues.apache.org/jira/browse/CXF-6845
>             Project: CXF
>          Issue Type: Bug
>    Affects Versions: 3.0.9
>            Reporter: Francesco Chicchiriccò
>         Attachments: CXF-6845.diff
>
>
> When attempting to upgrade Syncope 1.2 from CXF 3.0.8 to 3.0.9, I receive NPE due to some methods in {{MessageUtils}} - see for example
> {code}
>     public static boolean getContextualBoolean(Message m, String key, boolean defaultValue) {
>         Object o = m.getContextualProperty(key);
>         if (o != null) {
>             return PropertyUtils.isTrue(o);
>         }
>         return defaultValue;
>     }
> {code}
> As you can see, if {{m}} is NULL, NPE is thrown.
> See for reference the same method from 3.1.6:
> {code}
>     public static boolean getContextualBoolean(Message m, String key, boolean defaultValue) {
>         if (m != null) {
>             Object o = m.getContextualProperty(key);
>             if (o != null) {
>                 return PropertyUtils.isTrue(o);
>             }
>         }
>         return defaultValue;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)