You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "featzhang (via GitHub)" <gi...@apache.org> on 2023/03/29 14:22:20 UTC
[GitHub] [inlong] featzhang opened a new pull request, #7727: [INLONG-7719][Manager] Support test connection for Redis in NodeManagement
featzhang opened a new pull request, #7727:
URL: https://github.com/apache/inlong/pull/7727
### Prepare a Pull Request
*[INLONG-7719][Manager] Support test connection for Redis in NodeManagement*
- Fixes #7719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang closed pull request #7727: [INLONG-7719][Manager] Support test connection for Redis in NodeManagement
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang closed pull request #7727: [INLONG-7719][Manager] Support test connection for Redis in NodeManagement
URL: https://github.com/apache/inlong/pull/7727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7727: [INLONG-7719][Manager] Support test connection for Redis in NodeManagement
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7727:
URL: https://github.com/apache/inlong/pull/7727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang commented on pull request #7727: [INLONG-7719][Manager] Support test connection for Redis in NodeManagement
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on PR #7727:
URL: https://github.com/apache/inlong/pull/7727#issuecomment-1491188173
The cluster-related fields of `node management` need to be extracted, and have been processed in another pr https://github.com/apache/inlong/pull/7741, and then adapt this PR after completion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang closed pull request #7727: [INLONG-7719][Manager] Support test connection for Redis in NodeManagement
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang closed pull request #7727: [INLONG-7719][Manager] Support test connection for Redis in NodeManagement
URL: https://github.com/apache/inlong/pull/7727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] featzhang commented on a diff in pull request #7727: [INLONG-7719][Manager] Support test connection for Redis in NodeManagement
Posted by "featzhang (via GitHub)" <gi...@apache.org>.
featzhang commented on code in PR #7727:
URL: https://github.com/apache/inlong/pull/7727#discussion_r1156190020
##########
pom.xml:
##########
@@ -206,6 +206,7 @@
<os.maven.plugin.version>1.6.0</os.maven.plugin.version>
<kudu.version>1.16.0</kudu.version>
<tomcat.version>8.5.53</tomcat.version>
+ <jedis.version>2.9.0</jedis.version>
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7727: [INLONG-7719][Manager] Support test connection for Redis in NodeManagement
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7727:
URL: https://github.com/apache/inlong/pull/7727#discussion_r1155337082
##########
pom.xml:
##########
@@ -206,6 +206,7 @@
<os.maven.plugin.version>1.6.0</os.maven.plugin.version>
<kudu.version>1.16.0</kudu.version>
<tomcat.version>8.5.53</tomcat.version>
+ <jedis.version>2.9.0</jedis.version>
Review Comment:
Do we need add the license or notice file for the jedis dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org