You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/05 01:08:11 UTC
[GitHub] [iceberg] kbendick opened a new pull request, #4696: Core: Fix invalid null handling in JsonUtils::getIntOrNull ::getLongOrNull
kbendick opened a new pull request, #4696:
URL: https://github.com/apache/iceberg/pull/4696
Using `JsonUtils::getLongOrNull` in https://github.com/apache/iceberg/pull/4693, it seems that the functions `getIntOrNull` and `getLongOrNull` do not properly handle an explicit null.
As you can see in the `Preconditions` check, after getting the property, if the JsonNode of the nullable Integer or Long is explicitly `null`, the Precondition check will fail.
cc @rdblue @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks merged pull request #4696: Core: Fix invalid null handling in JsonUtils::getIntOrNull ::getLongOrNull
Posted by GitBox <gi...@apache.org>.
danielcweeks merged PR #4696:
URL: https://github.com/apache/iceberg/pull/4696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4696: Core: Fix invalid null handling in JsonUtils::getIntOrNull ::getLongOrNull
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4696:
URL: https://github.com/apache/iceberg/pull/4696#issuecomment-1119814130
+1
Good catch, @kbendick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org