You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/02/05 10:03:48 UTC
[GitHub] [buildstream] BuildStream-Migration-Bot opened a new issue #1409: Remove fix-python-timestamps from master
BuildStream-Migration-Bot opened a new issue #1409:
URL: https://github.com/apache/buildstream/issues/1409
[See original issue on GitLab](https://gitlab.com/BuildStream/buildstream/-/issues/1409)
In GitLab by [[Gitlab user @nanonyme]](https://gitlab.com/nanonyme) on Nov 10, 2020, 21:00
## Background
[//]: # (Provide a background or the root/source that justifies this task or action.)
Before Python 3.7 Python bytecode was not deterministic ever. BuildStream worked around this through through resetting timestamps. These days Python 3.7 and higher produce hashed bytecode when SOURCE_DATE_EPOCH is set so the feature is more harmful than useful as a default. (the BuildStream code breaks hashed bytecode so it's always invalid)
## Task description
[//]: # (Short summary of the action to be executed)
* [x] Remove usage of fix-python-timestamps from distutils plugin in bst-plugins-experimental
* [x] Remove usage of fix-python-timestamps from pip plugin in bst-plugins-experimental
* [ ] Remove variable fix-python-timestamps from project defaults
## Acceptance Criteria
[//]: # (Acceptance criteria should follow the S.M.A.R.T. principle https://en.wikipedia.org/wiki/SMART_criteria )
fix-python-timestamps is gone from project defaults and plugins don't break
----
[//]: # (To review information about possible relevant labels for this issue please view the list of labels: https://gitlab.com/BuildStream/buildstream/labels)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on issue #1409: Remove fix-python-timestamps from master
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on issue #1409:
URL: https://github.com/apache/buildstream/issues/1409#issuecomment-773069361
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan closed issue #1409: Remove fix-python-timestamps from master
Posted by GitBox <gi...@apache.org>.
gtristan closed issue #1409:
URL: https://github.com/apache/buildstream/issues/1409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on issue #1409: Remove fix-python-timestamps from master
Posted by GitBox <gi...@apache.org>.
gtristan commented on issue #1409:
URL: https://github.com/apache/buildstream/issues/1409#issuecomment-913435828
This is closed with #1509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org