[jira] [Commented] (PARQUET-1659) Add AES-CTR to Parquet Encryption

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934758#comment-16934758 ] 

ASF GitHub Bot commented on PARQUET-1659:
-----------------------------------------

shangxinli commented on pull request #153: PARQUET-1659: Add AES-CTR to Parquet Encryption
URL: https://github.com/apache/parquet-format/pull/153
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add AES-CTR to Parquet Encryption 
> ----------------------------------
>
>                 Key: PARQUET-1659
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1659
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp, parquet-format, parquet-mr
>    Affects Versions: format-2.6.0
>            Reporter: Xinli Shang
>            Priority: Minor
>              Labels: pull-request-available
>
> AES-GCM-CTR perform GCM encryption on metadata and CTR encryption on data.
> AES-CTR would perform CTR encryption on both. 
> During Perf testing, we found AES-CTR can improve read/write performance by ~10% comparing with AES-GCM-CTR.
>  
> I checked with Gidon and the initial assumption was that AES-GCM-CTR would have similar performance as AES-CTR. But with recent performance benchmarking, we found it is worthy to introduce AES-CTR. Since many companies strive for parquet performance improvement. 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)