You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by si...@apache.org on 2019/06/11 19:31:29 UTC

[lucene-solr] branch branch_8x updated: LUCENE-8853: Temporarily disable random FileSwitchDirectory

This is an automated email from the ASF dual-hosted git repository.

simonw pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/branch_8x by this push:
     new 213abb7  LUCENE-8853: Temporarily disable random FileSwitchDirectory
213abb7 is described below

commit 213abb7e4a4ca0be7e03bfbfb1a12f28c490151d
Author: Simon Willnauer <si...@apache.org>
AuthorDate: Tue Jun 11 21:31:08 2019 +0200

    LUCENE-8853: Temporarily disable random FileSwitchDirectory
---
 .../src/java/org/apache/lucene/util/LuceneTestCase.java   | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java
index 0537524..6d9d1b4 100644
--- a/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java
+++ b/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java
@@ -1416,13 +1416,14 @@ public abstract class LuceneTestCase extends Assert {
       }
 
       Directory fsdir = newFSDirectoryImpl(clazz, f, lf);
-      if (rarely()) {
-        List<String> fileExtensions =
-            Arrays.asList("fdt", "fdx", "tim", "tip", "si", "fnm", "pos", "dii", "dim", "nvm", "nvd", "dvm", "dvd");
-        Collections.shuffle(fileExtensions, random());
-        fileExtensions = fileExtensions.subList(0, 1 + random().nextInt(fileExtensions.size()));
-        fsdir = new FileSwitchDirectory(new HashSet<>(fileExtensions), fsdir, newFSDirectoryImpl(clazz, f, lf), true);
-      }
+// LUCENE-8853: FileSwitchDirectory is broken for tmp outputs.
+//      if (rarely()) {
+//        List<String> fileExtensions =
+//            Arrays.asList("fdt", "fdx", "tim", "tip", "si", "fnm", "pos", "dii", "dim", "nvm", "nvd", "dvm", "dvd");
+//        Collections.shuffle(fileExtensions, random());
+//        fileExtensions = fileExtensions.subList(0, 1 + random().nextInt(fileExtensions.size()));
+//        fsdir = new FileSwitchDirectory(new HashSet<>(fileExtensions), fsdir, newFSDirectoryImpl(clazz, f, lf), true);
+//      }
       BaseDirectoryWrapper wrapped = wrapDirectory(random(), fsdir, bare);
       return wrapped;
     } catch (Exception e) {