You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/12 14:49:57 UTC
[GitHub] [skywalking-satellite] EvanLjp opened a new pull request #14: add plugin doc generator
EvanLjp opened a new pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14
add add plugin doc generator
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] membphis commented on a change in pull request #14: add plugin doc generator
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14#discussion_r557024970
##########
File path: internal/satellite/tools/generate_plugin_doc.go
##########
@@ -0,0 +1,89 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package tools
+
+import (
+ "fmt"
+ "io/ioutil"
+ "os"
+ "reflect"
+ "sort"
+ "strings"
+
+ "github.com/apache/skywalking-satellite/internal/pkg/log"
+ "github.com/apache/skywalking-satellite/internal/pkg/plugin"
+ "github.com/apache/skywalking-satellite/plugins"
+)
+
+const (
+ docDir = "docs"
+ docPath = docDir + "/plugin-description.md"
Review comment:
I think you can submit a PR directly ^_^ @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on pull request #14: add plugin doc generator
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14#issuecomment-758709797
> CI fails, please fix.
fixing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] moonming commented on a change in pull request #14: add plugin doc generator
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14#discussion_r557019096
##########
File path: internal/satellite/tools/generate_plugin_doc.go
##########
@@ -0,0 +1,89 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package tools
+
+import (
+ "fmt"
+ "io/ioutil"
+ "os"
+ "reflect"
+ "sort"
+ "strings"
+
+ "github.com/apache/skywalking-satellite/internal/pkg/log"
+ "github.com/apache/skywalking-satellite/internal/pkg/plugin"
+ "github.com/apache/skywalking-satellite/plugins"
+)
+
+const (
+ docDir = "docs"
+ docPath = docDir + "/plugin-description.md"
Review comment:
welcome PR to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] nic-chen commented on a change in pull request #14: add plugin doc generator
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14#discussion_r557033391
##########
File path: internal/satellite/tools/generate_plugin_doc.go
##########
@@ -0,0 +1,89 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package tools
+
+import (
+ "fmt"
+ "io/ioutil"
+ "os"
+ "reflect"
+ "sort"
+ "strings"
+
+ "github.com/apache/skywalking-satellite/internal/pkg/log"
+ "github.com/apache/skywalking-satellite/internal/pkg/plugin"
+ "github.com/apache/skywalking-satellite/plugins"
+)
+
+const (
+ docDir = "docs"
+ docPath = docDir + "/plugin-description.md"
Review comment:
sure, thanks for remind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp merged pull request #14: add plugin doc generator
Posted by GitBox <gi...@apache.org>.
EvanLjp merged pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #14: add plugin doc generator
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14#discussion_r557034230
##########
File path: internal/satellite/tools/generate_plugin_doc.go
##########
@@ -0,0 +1,89 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package tools
+
+import (
+ "fmt"
+ "io/ioutil"
+ "os"
+ "reflect"
+ "sort"
+ "strings"
+
+ "github.com/apache/skywalking-satellite/internal/pkg/log"
+ "github.com/apache/skywalking-satellite/internal/pkg/plugin"
+ "github.com/apache/skywalking-satellite/plugins"
+)
+
+const (
+ docDir = "docs"
+ docPath = docDir + "/plugin-description.md"
Review comment:
Using a function in `const` is not allowed, unless you want to change all `const` to `var`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] nic-chen commented on a change in pull request #14: add plugin doc generator
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14#discussion_r557064386
##########
File path: internal/satellite/tools/generate_plugin_doc.go
##########
@@ -0,0 +1,89 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package tools
+
+import (
+ "fmt"
+ "io/ioutil"
+ "os"
+ "reflect"
+ "sort"
+ "strings"
+
+ "github.com/apache/skywalking-satellite/internal/pkg/log"
+ "github.com/apache/skywalking-satellite/internal/pkg/plugin"
+ "github.com/apache/skywalking-satellite/plugins"
+)
+
+const (
+ docDir = "docs"
+ docPath = docDir + "/plugin-description.md"
Review comment:
@kezhenxu94
you're right. There is little benefit from such modification.
I submitted another pr, welcome to review, thanks.
https://github.com/apache/skywalking-satellite/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #14: add plugin doc generator
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14#issuecomment-758709299
CI fails, please fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] nic-chen commented on a change in pull request #14: add plugin doc generator
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #14:
URL: https://github.com/apache/skywalking-satellite/pull/14#discussion_r556999806
##########
File path: internal/satellite/tools/generate_plugin_doc.go
##########
@@ -0,0 +1,89 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package tools
+
+import (
+ "fmt"
+ "io/ioutil"
+ "os"
+ "reflect"
+ "sort"
+ "strings"
+
+ "github.com/apache/skywalking-satellite/internal/pkg/log"
+ "github.com/apache/skywalking-satellite/internal/pkg/plugin"
+ "github.com/apache/skywalking-satellite/plugins"
+)
+
+const (
+ docDir = "docs"
+ docPath = docDir + "/plugin-description.md"
Review comment:
we could use `filepath.Join` instead of concatenating them manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org