You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "SWJTU-ZhangLei (via GitHub)" <gi...@apache.org> on 2024/10/28 09:34:55 UTC
[PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
SWJTU-ZhangLei opened a new pull request, #42629:
URL: https://github.com/apache/doris/pull/42629
* https://brpc.apache.org/docs/server/basics/
* According to the brpc doc, `JNI code checks stack layout and cannot be run in bthreads` so create a pthread for creating hdfs connection if necessary.
## Proposed changes
Issue Number: close #42610
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2449465907
<details>
<summary>TPC-H: <b>Total hot run time: 41274 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit add0eb537ea1037bafbe423b494777020ed4fac5, data reload: false
------ Round 1 ----------------------------------
q1 17594 7374 7289 7289
q2 2067 157 153 153
q3 10586 1080 1127 1080
q4 10552 793 872 793
q5 7740 2999 3060 2999
q6 236 146 141 141
q7 1017 590 595 590
q8 9354 1949 1994 1949
q9 6584 6412 6434 6412
q10 7071 2464 2459 2459
q11 446 239 253 239
q12 401 220 213 213
q13 17785 3007 2998 2998
q14 242 202 214 202
q15 571 510 524 510
q16 655 590 579 579
q17 965 541 538 538
q18 7284 6799 6725 6725
q19 1320 1102 1067 1067
q20 476 178 182 178
q21 3963 3148 3204 3148
q22 1092 1038 1012 1012
Total cold run time: 108001 ms
Total hot run time: 41274 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7235 7239 7344 7239
q2 319 227 223 223
q3 2977 2955 2943 2943
q4 2113 1891 1773 1773
q5 5728 5760 5754 5754
q6 230 143 143 143
q7 2223 1857 1815 1815
q8 3359 3578 3449 3449
q9 8938 8955 8885 8885
q10 3612 3603 3536 3536
q11 587 494 499 494
q12 801 672 644 644
q13 10496 3194 3170 3170
q14 312 267 276 267
q15 581 517 520 517
q16 699 653 633 633
q17 1871 1619 1593 1593
q18 8418 7810 7661 7661
q19 1696 1514 1461 1461
q20 2094 1833 1877 1833
q21 5775 5369 5548 5369
q22 1143 1045 1050 1045
Total cold run time: 71207 ms
Total hot run time: 60447 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2447277315
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2449409080
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446018798
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2449504361
<details>
<summary>ClickBench: <b>Total hot run time: 32.99 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit add0eb537ea1037bafbe423b494777020ed4fac5, data reload: false
query1 0.03 0.03 0.03
query2 0.07 0.03 0.03
query3 0.23 0.06 0.06
query4 1.64 0.10 0.10
query5 0.40 0.41 0.40
query6 1.15 0.64 0.66
query7 0.02 0.01 0.03
query8 0.04 0.03 0.02
query9 0.55 0.49 0.50
query10 0.56 0.56 0.55
query11 0.14 0.10 0.11
query12 0.13 0.11 0.11
query13 0.62 0.60 0.60
query14 2.77 2.86 2.83
query15 0.91 0.83 0.84
query16 0.38 0.38 0.38
query17 1.09 1.01 1.07
query18 0.20 0.21 0.20
query19 1.97 1.88 2.06
query20 0.01 0.01 0.01
query21 15.37 0.60 0.57
query22 2.81 2.40 1.94
query23 17.06 0.99 0.64
query24 2.75 1.50 1.39
query25 0.22 0.15 0.04
query26 0.49 0.14 0.13
query27 0.05 0.04 0.04
query28 10.43 1.12 1.09
query29 12.54 3.28 3.28
query30 0.24 0.06 0.06
query31 2.86 0.40 0.39
query32 3.27 0.46 0.46
query33 3.03 3.11 3.03
query34 17.23 4.51 4.45
query35 4.50 4.51 4.42
query36 0.66 0.48 0.48
query37 0.09 0.05 0.06
query38 0.05 0.03 0.03
query39 0.04 0.02 0.02
query40 0.16 0.13 0.13
query41 0.08 0.02 0.02
query42 0.03 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 106.9 s
Total hot run time: 32.99 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #42629:
URL: https://github.com/apache/doris/pull/42629#discussion_r1822263792
##########
be/src/io/hdfs_util.cpp:
##########
@@ -41,6 +43,22 @@ Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name
return Status::OK();
}
+bool is_bthread() {
+ return (bthread_self() != 0);
+}
+
+Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name, hdfsFS* fs) {
+ if (is_bthread()) {
+ Status st;
+ std::thread t([&] { st = _create_hdfs_fs(hdfs_params, fs_name, fs); });
+ if (t.joinable()) {
+ t.join();
+ }
+ return st;
+ }
+ return _create_hdfs_fs(hdfs_params, fs_name, fs);
+}
Review Comment:
```suggestion
// https://brpc.apache.org/docs/server/basics/
// According to the brpc doc, JNI code checks stack layout and cannot be run in
// bthreads so create a pthread for creating hdfs connection if necessary.
Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name, hdfsFS* fs) {
if (bthread_self() != 0) { // running in bthread
Status st;
std::thread t([&] { st = _create_hdfs_fs(hdfs_params, fs_name, fs); });
if (t.joinable()) {
t.join();
}
return st;
}
return _create_hdfs_fs(hdfs_params, fs_name, fs);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #42629:
URL: https://github.com/apache/doris/pull/42629#discussion_r1818973034
##########
be/src/io/hdfs_util.cpp:
##########
@@ -41,6 +44,54 @@ Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name
return Status::OK();
}
+Status create_hdfs_fs_async(const THdfsParams& hdfs_params, const std::string& fs_name,
+ hdfsFS* fs) {
+ std::promise<std::pair<Status, hdfsFS>> prom;
+ std::future<std::pair<Status, hdfsFS>> fut = prom.get_future();
+
+ std::thread t(
+ [&](std::promise<std::pair<Status, hdfsFS>> prom) {
Review Comment:
why not just call `create_hdfs_fs_sync()` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #42629:
URL: https://github.com/apache/doris/pull/42629#discussion_r1818723288
##########
be/src/io/hdfs_util.cpp:
##########
@@ -41,6 +44,54 @@ Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name
return Status::OK();
}
+Status create_hdfs_fs_async(const THdfsParams& hdfs_params, const std::string& fs_name,
+ hdfsFS* fs) {
+ std::promise<std::pair<Status, hdfsFS>> prom;
+ std::future<std::pair<Status, hdfsFS>> fut = prom.get_future();
+
+ std::thread t(
+ [&](std::promise<std::pair<Status, hdfsFS>> prom) {
+ HDFSCommonBuilder builder;
+ Status status = create_hdfs_builder(hdfs_params, fs_name, &builder);
+ if (status != Status::OK()) {
+ prom.set_value(std::make_pair(status, nullptr));
+ return;
+ }
+ hdfsFS hdfs_fs = hdfsBuilderConnect(builder.get());
+ if (hdfs_fs == nullptr) {
+ prom.set_value(std::make_pair(
+ Status::InternalError("failed to connect to hdfs {}: {}, in bthread",
+ fs_name, hdfs_error()),
+ nullptr));
+ return;
+ }
+ prom.set_value(std::make_pair(Status::OK(), hdfs_fs));
+ return;
+ },
+ std::move(prom));
+
+ auto [status, hdfs_fs] = fut.get();
+ if (t.joinable()) {
+ t.join();
+ }
+
+ if (status == Status::OK()) {
+ *fs = hdfs_fs;
+ }
+ return status;
+}
+
+inline bool is_bthread() {
Review Comment:
warning: 'is_bthread' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
```suggestion
inline bool is_bthread() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "SWJTU-ZhangLei (via GitHub)" <gi...@apache.org>.
SWJTU-ZhangLei commented on code in PR #42629:
URL: https://github.com/apache/doris/pull/42629#discussion_r1819994956
##########
be/src/io/hdfs_util.cpp:
##########
@@ -41,6 +44,54 @@ Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name
return Status::OK();
}
+Status create_hdfs_fs_async(const THdfsParams& hdfs_params, const std::string& fs_name,
+ hdfsFS* fs) {
+ std::promise<std::pair<Status, hdfsFS>> prom;
+ std::future<std::pair<Status, hdfsFS>> fut = prom.get_future();
+
+ std::thread t(
+ [&](std::promise<std::pair<Status, hdfsFS>> prom) {
Review Comment:
> why not just call `create_hdfs_fs_sync()` here?
for returning multi value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446066291
TeamCity be ut coverage result:
Function Coverage: 37.93% (9844/25952)
Line Coverage: 29.21% (81977/280645)
Region Coverage: 28.55% (42269/148055)
Branch Coverage: 25.08% (21486/85664)
Coverage Report: http://coverage.selectdb-in.cc/coverage/52e27dc00145010166b33807d4133d5bb7265612_52e27dc00145010166b33807d4133d5bb7265612/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "SWJTU-ZhangLei (via GitHub)" <gi...@apache.org>.
SWJTU-ZhangLei commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446115297
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446015120
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446889396
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446393717
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2441057212
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #42629:
URL: https://github.com/apache/doris/pull/42629#discussion_r1818718999
##########
be/src/io/hdfs_util.cpp:
##########
@@ -41,6 +44,54 @@ Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name
return Status::OK();
}
+Status create_hdfs_fs_async(const THdfsParams& hdfs_params, const std::string& fs_name,
+ hdfsFS* fs) {
+ std::promise<std::pair<Status, hdfsFS>> prom;
+ std::future<std::pair<Status, hdfsFS>> fut = prom.get_future();
+
+ std::thread t(
+ [&](std::promise<std::pair<Status, hdfsFS>> prom) {
+ HDFSCommonBuilder builder;
+ Status status = create_hdfs_builder(hdfs_params, fs_name, &builder);
+ if (status != Status::OK()) {
+ prom.set_value(std::make_pair(status, nullptr));
+ return;
+ }
+ hdfsFS hdfs_fs = hdfsBuilderConnect(builder.get());
+ if (hdfs_fs == nullptr) {
+ prom.set_value(std::make_pair(
+ Status::InternalError("failed to connect to hdfs {}: {}, in bthread",
+ fs_name, hdfs_error()),
+ nullptr));
+ return;
+ }
+ prom.set_value(std::make_pair(Status::OK(), hdfs_fs));
+ return;
+ },
+ std::move(prom));
+
+ auto [status, hdfs_fs] = fut.get();
+ if (t.joinable()) {
+ t.join();
+ }
+
+ if (status == Status::OK()) {
+ *fs = hdfs_fs;
+ }
+ return status;
+}
+
+static inline bool is_bthread() {
Review Comment:
warning: 'is_bthread' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
```suggestion
inline bool is_bthread() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2449593075
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446393586
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446742038
TeamCity be ut coverage result:
Function Coverage: 37.90% (9848/25987)
Line Coverage: 29.16% (81985/281137)
Region Coverage: 28.54% (42316/148258)
Branch Coverage: 25.05% (21492/85784)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3c231ae4e850f6d3459f3e8dc3bafb68ca530fef_3c231ae4e850f6d3459f3e8dc3bafb68ca530fef/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2449055190
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2449457222
TeamCity be ut coverage result:
Function Coverage: 37.94% (9850/25962)
Line Coverage: 29.19% (82074/281140)
Region Coverage: 28.44% (42339/148865)
Branch Coverage: 25.02% (21512/85990)
Coverage Report: http://coverage.selectdb-in.cc/coverage/add0eb537ea1037bafbe423b494777020ed4fac5_add0eb537ea1037bafbe423b494777020ed4fac5/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2449494743
<details>
<summary>TPC-DS: <b>Total hot run time: 195318 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit add0eb537ea1037bafbe423b494777020ed4fac5, data reload: false
query1 1221 929 903 903
query2 6248 2001 2046 2001
query3 10766 3989 3724 3724
query4 68188 27837 23565 23565
query5 4949 456 447 447
query6 396 188 187 187
query7 5533 290 290 290
query8 310 225 219 219
query9 8488 2611 2596 2596
query10 439 252 244 244
query11 17101 15379 15960 15379
query12 160 101 107 101
query13 1465 414 429 414
query14 10779 7153 6756 6756
query15 209 188 201 188
query16 7171 466 469 466
query17 1016 558 560 558
query18 1769 298 288 288
query19 196 148 143 143
query20 112 116 117 116
query21 201 100 102 100
query22 4483 4157 4293 4157
query23 34420 34079 34308 34079
query24 5999 2725 2791 2725
query25 508 381 393 381
query26 643 156 154 154
query27 1658 281 285 281
query28 4336 2399 2403 2399
query29 697 428 428 428
query30 235 155 150 150
query31 960 850 818 818
query32 62 56 54 54
query33 424 264 266 264
query34 939 533 536 533
query35 864 716 759 716
query36 1085 983 990 983
query37 132 80 74 74
query38 4538 4347 4380 4347
query39 1516 1465 1421 1421
query40 198 97 100 97
query41 46 46 44 44
query42 108 97 94 94
query43 505 494 476 476
query44 1171 817 812 812
query45 185 162 163 162
query46 1114 695 675 675
query47 1940 1837 1851 1837
query48 426 331 327 327
query49 742 400 386 386
query50 803 411 394 394
query51 7285 7065 7109 7065
query52 102 83 87 83
query53 252 181 185 181
query54 546 394 386 386
query55 74 75 72 72
query56 238 226 219 219
query57 1287 1167 1141 1141
query58 205 191 203 191
query59 3089 3128 3255 3128
query60 273 238 244 238
query61 103 99 105 99
query62 784 691 679 679
query63 220 184 186 184
query64 1307 648 599 599
query65 3277 3248 3208 3208
query66 736 298 304 298
query67 15841 15769 15649 15649
query68 3795 580 564 564
query69 421 255 258 255
query70 1198 1152 1136 1136
query71 364 243 250 243
query72 6317 3967 4056 3967
query73 766 356 355 355
query74 10187 8985 9016 8985
query75 3409 2679 2661 2661
query76 1780 1057 1215 1057
query77 495 272 270 270
query78 10498 9402 9389 9389
query79 1916 579 588 579
query80 1360 417 422 417
query81 547 240 241 240
query82 1296 113 114 113
query83 236 135 131 131
query84 275 67 72 67
query85 1050 299 278 278
query86 412 309 292 292
query87 4906 4722 4622 4622
query88 3756 2180 2155 2155
query89 414 285 295 285
query90 1952 184 179 179
query91 133 102 100 100
query92 61 47 51 47
query93 2604 542 536 536
query94 840 289 288 288
query95 357 242 245 242
query96 629 277 284 277
query97 2939 2705 2727 2705
query98 219 208 196 196
query99 1599 1314 1314 1314
Total cold run time: 319804 ms
Total hot run time: 195318 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2441082179
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446403813
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446186791
<details>
<summary>TPC-H: <b>Total hot run time: 41964 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 78e8a6e98e4095ce584b78d2e59d08ee3d87e197, data reload: false
------ Round 1 ----------------------------------
q1 17657 7472 7418 7418
q2 2054 165 160 160
q3 11538 1079 1151 1079
q4 10230 875 857 857
q5 7753 3096 3027 3027
q6 235 150 151 150
q7 1015 601 615 601
q8 9388 1982 2030 1982
q9 6614 6528 6496 6496
q10 7078 2461 2483 2461
q11 446 252 252 252
q12 444 220 217 217
q13 19593 3109 3104 3104
q14 266 251 247 247
q15 577 546 538 538
q16 1033 601 589 589
q17 975 540 577 540
q18 8990 7096 6857 6857
q19 1413 1052 1025 1025
q20 471 185 189 185
q21 4051 3262 3210 3210
q22 1116 1023 969 969
Total cold run time: 112937 ms
Total hot run time: 41964 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7287 7242 7318 7242
q2 340 230 232 230
q3 3085 2936 3087 2936
q4 2056 1845 1842 1842
q5 5769 5795 5814 5795
q6 229 141 140 140
q7 2189 1856 1775 1775
q8 3311 3516 3501 3501
q9 8861 8855 8888 8855
q10 3586 3593 3544 3544
q11 586 491 498 491
q12 838 632 633 632
q13 14321 3165 3216 3165
q14 298 260 281 260
q15 579 536 517 517
q16 678 658 655 655
q17 1857 1638 1630 1630
q18 8254 7788 7851 7788
q19 1699 1635 1679 1635
q20 2157 1863 1888 1863
q21 5547 5441 5415 5415
q22 1164 1070 1029 1029
Total cold run time: 74691 ms
Total hot run time: 60940 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446180656
TeamCity be ut coverage result:
Function Coverage: 37.94% (9846/25952)
Line Coverage: 29.22% (81995/280645)
Region Coverage: 28.56% (42284/148055)
Branch Coverage: 25.09% (21491/85664)
Coverage Report: http://coverage.selectdb-in.cc/coverage/78e8a6e98e4095ce584b78d2e59d08ee3d87e197_78e8a6e98e4095ce584b78d2e59d08ee3d87e197/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "SWJTU-ZhangLei (via GitHub)" <gi...@apache.org>.
SWJTU-ZhangLei commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446012809
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446225194
<details>
<summary>ClickBench: <b>Total hot run time: 31.68 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 78e8a6e98e4095ce584b78d2e59d08ee3d87e197, data reload: false
query1 0.04 0.03 0.02
query2 0.06 0.03 0.02
query3 0.23 0.07 0.07
query4 1.64 0.10 0.10
query5 0.42 0.42 0.41
query6 1.14 0.64 0.65
query7 0.02 0.02 0.01
query8 0.04 0.03 0.03
query9 0.56 0.50 0.50
query10 0.55 0.55 0.56
query11 0.14 0.10 0.11
query12 0.14 0.11 0.11
query13 0.61 0.59 0.58
query14 2.71 2.74 2.84
query15 0.90 0.82 0.82
query16 0.39 0.38 0.38
query17 0.98 1.03 1.05
query18 0.20 0.19 0.19
query19 1.99 1.90 1.88
query20 0.02 0.01 0.02
query21 15.35 0.57 0.57
query22 2.33 2.40 1.66
query23 17.04 1.06 0.78
query24 3.59 0.26 1.96
query25 0.33 0.13 0.16
query26 0.39 0.14 0.14
query27 0.04 0.05 0.05
query28 10.36 1.08 1.08
query29 12.57 3.29 3.32
query30 0.27 0.08 0.06
query31 2.85 0.38 0.37
query32 3.30 0.47 0.45
query33 2.97 2.96 3.07
query34 16.61 4.43 4.44
query35 4.55 4.48 4.49
query36 0.67 0.47 0.48
query37 0.08 0.06 0.06
query38 0.04 0.04 0.04
query39 0.03 0.02 0.02
query40 0.16 0.12 0.13
query41 0.08 0.03 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 106.46 s
Total hot run time: 31.68 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #42629:
URL: https://github.com/apache/doris/pull/42629#discussion_r1822710982
##########
be/src/io/hdfs_util.cpp:
##########
@@ -41,6 +43,21 @@ Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name
return Status::OK();
}
+// https://brpc.apache.org/docs/server/basics/
+// According to the brpc doc, JNI code checks stack layout and cannot be run in
+// bthreads so create a pthread for creating hdfs connection if necessary.
+Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name, hdfsFS* fs) {
+ if (bthread_self() != 0) { // running in bthread
+ Status st;
+ std::thread t([&] { st = _create_hdfs_fs(hdfs_params, fs_name, fs); });
+ if (t.joinable()) {
+ t.join();
+ }
+ return st;
+ }
+ return _create_hdfs_fs(hdfs_params, fs_name, fs);
+}
Review Comment:
```suggestion
// https://brpc.apache.org/docs/server/basics/
// According to the brpc doc, JNI code checks stack layout and cannot be run in
// bthreads so create a pthread for creating hdfs connection if necessary.
Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name, hdfsFS* fs) {
if (bthread_self() != 0) { // running in bthread
Status st;
auto btx = butex_create();
std::atomic_bool done = false;
std::thread t([&] {
st = _create_hdfs_fs(hdfs_params, fs_name, fs);
done = true;
butex_wake(btx);
});
if (!done) butex_wait(btx);
butex_destroy(btx);
if (t.joinable()) {
t.join();
}
return st;
}
return _create_hdfs_fs(hdfs_params, fs_name, fs);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "SWJTU-ZhangLei (via GitHub)" <gi...@apache.org>.
SWJTU-ZhangLei commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2441057461
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446415603
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446122649
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #42629:
URL: https://github.com/apache/doris/pull/42629#discussion_r1822720578
##########
be/src/io/hdfs_util.cpp:
##########
@@ -41,6 +43,29 @@ Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name
return Status::OK();
}
+// https://brpc.apache.org/docs/server/basics/
+// According to the brpc doc, JNI code checks stack layout and cannot be run in
+// bthreads so create a pthread for creating hdfs connection if necessary.
+Status create_hdfs_fs(const THdfsParams& hdfs_params, const std::string& fs_name, hdfsFS* fs) {
+ if (bthread_self() != 0) { // running in bthread
+ Status st;
+ auto btx = butex_create();
+ std::atomic_bool done = false;
+ std::thread t([&] {
+ st = _create_hdfs_fs(hdfs_params, fs_name, fs);
+ done = true;
+ butex_wake(btx);
+ });
+ if (!done) butex_wait(btx);
Review Comment:
warning: statement should be inside braces [readability-braces-around-statements]
```suggestion
if (!done) { butex_wait(btx);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42629:
URL: https://github.com/apache/doris/pull/42629#issuecomment-2446213576
<details>
<summary>TPC-DS: <b>Total hot run time: 197005 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 78e8a6e98e4095ce584b78d2e59d08ee3d87e197, data reload: false
query1 1204 783 770 770
query2 6211 2128 2085 2085
query3 11502 4681 4816 4681
query4 33732 23552 23727 23552
query5 4954 450 427 427
query6 274 192 174 174
query7 3984 292 295 292
query8 282 225 217 217
query9 9641 2725 2711 2711
query10 503 247 243 243
query11 18188 15352 15260 15260
query12 145 101 98 98
query13 1569 431 400 400
query14 9825 7247 7141 7141
query15 250 183 196 183
query16 7486 496 462 462
query17 1603 581 568 568
query18 2041 310 312 310
query19 355 149 151 149
query20 120 112 108 108
query21 204 105 105 105
query22 4842 4558 4609 4558
query23 34694 34082 34039 34039
query24 11023 2797 2841 2797
query25 625 404 403 403
query26 1149 158 154 154
query27 2195 282 278 278
query28 7369 2468 2439 2439
query29 782 417 416 416
query30 258 157 156 156
query31 1025 809 774 774
query32 87 58 55 55
query33 745 264 262 262
query34 920 494 518 494
query35 1030 871 872 871
query36 1112 948 949 948
query37 122 70 72 70
query38 4514 4428 4300 4300
query39 1505 1423 1405 1405
query40 203 100 98 98
query41 49 44 46 44
query42 111 96 98 96
query43 509 479 489 479
query44 1262 810 810 810
query45 184 166 169 166
query46 1148 696 693 693
query47 2001 1855 1875 1855
query48 418 331 336 331
query49 892 405 398 398
query50 814 379 387 379
query51 7140 6951 7013 6951
query52 96 88 87 87
query53 260 183 179 179
query54 1140 398 434 398
query55 77 76 78 76
query56 256 223 236 223
query57 1296 1190 1154 1154
query58 227 205 232 205
query59 3135 2886 2933 2886
query60 272 236 236 236
query61 103 94 96 94
query62 864 663 673 663
query63 211 181 184 181
query64 4015 634 635 634
query65 3280 3260 3204 3204
query66 908 300 298 298
query67 16262 15759 15989 15759
query68 4410 550 542 542
query69 434 259 254 254
query70 1212 1195 1167 1167
query71 310 251 247 247
query72 6246 3942 4040 3942
query73 760 348 349 348
query74 10293 9260 8983 8983
query75 3412 2654 2663 2654
query76 2592 1011 1063 1011
query77 379 272 269 269
query78 10603 9635 9531 9531
query79 1747 589 602 589
query80 1164 408 404 404
query81 564 245 236 236
query82 966 113 119 113
query83 238 144 139 139
query84 237 73 72 72
query85 1395 283 280 280
query86 387 310 301 301
query87 5166 4771 4676 4676
query88 3285 2167 2147 2147
query89 416 291 295 291
query90 1997 182 183 182
query91 137 98 99 98
query92 59 49 48 48
query93 1935 548 528 528
query94 893 292 291 291
query95 349 236 234 234
query96 622 275 275 275
query97 2900 2738 2733 2733
query98 212 199 202 199
query99 1535 1289 1306 1289
Total cold run time: 302058 ms
Total hot run time: 197005 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix creating hdfs connection coredump within bthread [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #42629:
URL: https://github.com/apache/doris/pull/42629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org