You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/07 19:03:01 UTC
[GitHub] [maven-release] michael-o opened a new pull request, #122: [MRELEASE-1089] Reduce the tag format to the project version only
michael-o opened a new pull request, #122:
URL: https://github.com/apache/maven-release/pull/122
This closes #122
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] hboutemy commented on pull request #122: [MRELEASE-1089] Reduce the default tag format to the project version only
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1120385400
please everywhere (even the commit message), please rephrase "reduce the tag format" to "reduce the default tag format"
on changing the default, I don't like it because it has implicit effect
I'd better add an explicit page showing how to change the tag name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] pzygielo commented on pull request #122: [MRELEASE-1089] Reduce the tag format to the project version only
Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1120270476
Will similar be applied to
https://github.com/apache/maven-release/blob/8cc2f45c2f424b176a45afc1e245639d56f31048/maven-release-manager/src/main/java/org/apache/maven/shared/release/policies/DefaultNamingPolicy.java#L34-L44?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] jgangemi commented on pull request #122: [MRELEASE-1089] Reduce the default tag format to the project version only
Posted by GitBox <gi...@apache.org>.
jgangemi commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1126084138
i’d like to second keeping the old format as default. we rely on this format for other tooling and needing to make changes on either side of they would be cumbersome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #122: [MRELEASE-1089] Reduce the default tag format to the project version only
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1120414504
> please everywhere (even the commit message), please rephrase "reduce the tag format" to "reduce the default tag format"
>
> on changing the default, I don't like it because it has implicit effect
>
> I'd better add an explicit page showing how to change the tag name
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #122: [MRELEASE-1089] Reduce the default tag format to the project version only
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1126042706
> I would also not change the default but rather document only how to change it. Changing it will lead to regressions for some users, where multiple releases are triggered from the same repo.
It is a major version after all and we'd provide an update documentation for this. Conventions change. If people blindly update and don't check the changelog means we will never be able to move forward.
@cstamas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] kwin commented on pull request #122: [MRELEASE-1089] Reduce the default tag format to the project version only
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1126029163
I would also not change the default but rather document only how to change it. Changing it will lead to regressions for some users, where multiple releases are triggered from the same repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #122: [MRELEASE-1089] Reduce the tag format to the project version only
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1120270763
> Will similar be applied to
>
> https://github.com/apache/maven-release/blob/8cc2f45c2f424b176a45afc1e245639d56f31048/maven-release-manager/src/main/java/org/apache/maven/shared/release/policies/DefaultNamingPolicy.java#L34-L44
> ?
Oh, very nice catch...
Yes, it should be consistent throughout, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #122: [MRELEASE-1089] Reduce the tag format to the project version only
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1120278102
@pzygielo Done. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] kwin commented on pull request #122: [MRELEASE-1089] Reduce the default tag format to the project version only
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1126080704
The old default may be too verbose but will IMHO never lead to a release failure while the new proposed default may fail. Therefore I consider the old default better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #122: [MRELEASE-1089] Reduce the default tag format to the project version only
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #122:
URL: https://github.com/apache/maven-release/pull/122#issuecomment-1126118759
> The old default may be too verbose but will IMHO never lead to a release failure while the new proposed default may fail. Therefore I consider the old default better!
That is an argument. I will on docs before I will consider this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org