You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rvesse <gi...@git.apache.org> on 2018/07/17 15:34:51 UTC
[GitHub] spark pull request #21796: [SPARK-24833][K8S][WIP] Add host name aliases fea...
GitHub user rvesse opened a pull request:
https://github.com/apache/spark/pull/21796
[SPARK-24833][K8S][WIP] Add host name aliases feature
## What changes were proposed in this pull request?
This adds a new feature to the driver and executor builders for K8S that
allows providing host name aliases into the K8S pods. This is useful
for environments where DNS is not usable or you need to add aliases to
make non-K8S services accessible.
For example in our environment we use host aliases to route internal system services e.g. Zookeeper without having to know the external host name of the system.
## How was this patch tested?
Added unit tests for this functionality, will add more tests in the next day or two.
CC @mccheah
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rvesse/spark SPARK-24833
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21796.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21796
----
commit 097937b4319ab5a7cca0da492492c7dcec431a8c
Author: Rob Vesse <rv...@...>
Date: 2018-07-17T15:27:07Z
[SPARK-24833][K8S] Add host name aliases feature
This adds a new feature to the driver and executor builders for K8S that
allows providing host name aliases into the K8S pods. This is useful
for environments where DNS is not usable or you need to add aliases to
make non-K8S services accessible.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21796: [SPARK-24833][K8S][WIP] Add host name aliases feature
Posted by liyinan926 <gi...@git.apache.org>.
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/21796
I think we decided not to take any new configuration options with https://issues.apache.org/jira/browse/SPARK-24434 being worked on. @mccheah @foxish.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21796: [SPARK-24833][K8S][WIP] Add host name aliases feature
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21796
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21796: [SPARK-24833][K8S][WIP] Add host name aliases feature
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21796
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21796: [SPARK-24833][K8S][WIP] Add host name aliases fea...
Posted by rvesse <gi...@git.apache.org>.
Github user rvesse closed the pull request at:
https://github.com/apache/spark/pull/21796
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21796: [SPARK-24833][K8S][WIP] Add host name aliases feature
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21796
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21796: [SPARK-24833][K8S][WIP] Add host name aliases feature
Posted by rvesse <gi...@git.apache.org>.
Github user rvesse commented on the issue:
https://github.com/apache/spark/pull/21796
@liyinan926 Ok, I will keep an eye on that issue
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21796: [SPARK-24833][K8S][WIP] Add host name aliases feature
Posted by rvesse <gi...@git.apache.org>.
Github user rvesse commented on the issue:
https://github.com/apache/spark/pull/21796
@felixcheung No problem, have already made a couple of comments on the design doc
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org