[GitHub] [incubator-weex] weex-bot edited a comment on issue #2635: heron-merge

[GitBox <gi...@apache.org>]

weex-bot edited a comment on issue #2635: heron-merge
URL: https://github.com/apache/incubator-weex/pull/2635#issuecomment-507494672
 
 
   
   <!--
     3 failure:  Code file ios/pla..., Code file ios/pla..., Code file ios/sdk...
     5 warning:  No Changelog chan..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C...
     1 messages
     
   -->
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Fails</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:no_entry_sign:</td>
         <td>Code file ios/playground/WeexDemo/WXDemoViewController.m has cn source code.</td>
       </tr>
     
   <tr>
         <td>:no_entry_sign:</td>
         <td>Code file ios/playground/WeexDemo/extend/handler/WXApmImpl.m does not have the copyright header.</td>
       </tr>
     
   <tr>
         <td>:no_entry_sign:</td>
         <td>Code file ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm does not have the copyright header.</td>
       </tr>
     </tbody>
   </table>
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Warnings</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:warning:</td>
         <td>No Changelog changes!</td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/RenderContainer.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/utils/TypefaceUtil.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
       </tr>
     </tbody>
   </table>
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Messages</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:book:</td>
         <td>danger test finished.</td>
       </tr>
     </tbody>
   </table>
   
   
   <p align="right">
     Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
   </p>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services