You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/04 06:06:31 UTC

[GitHub] [skywalking] huangyoje commented on issue #4441: Add finagle plugin (#4433)

huangyoje commented on issue #4441: Add finagle plugin (#4433)
URL: https://github.com/apache/skywalking/pull/4441#issuecomment-594344519
 
 
   > Please follow these four first
   > 
   > 1. Make codes well formatted, including comments of the codes
   > 2. Add unit tests to your plugin codes.
   > 3. Make CI and plugin integration test work
   > 4. supported doc update.
   
   OK!  I will follow these steps to improve.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services