[jira] [Commented] (PARQUET-1709) [C++]: Avoid unnecessary temporary std::shared_ptr copies

["Wes McKinney (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987240#comment-16987240 ] 

Wes McKinney commented on PARQUET-1709:
---------------------------------------

I agree with using {{std::move}} with {{shared_ptr}} at function call sites where the intent is truly to move. There may be places where shared_ptr is being copied where there is no need, we generally try to pass as {{const T&}} as a default unless there is some reason otherwise

> [C++]: Avoid unnecessary temporary std::shared_ptr copies
> ---------------------------------------------------------
>
>                 Key: PARQUET-1709
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1709
>             Project: Parquet
>          Issue Type: Bug
>            Reporter: Gawain BOLTON
>            Assignee: Gawain BOLTON
>            Priority: Major
>
> There are several occurences of copying of std::shared_ptr objects which are easily avoided.
> Copying of std::shared_ptr objects can be expensive due to the atomic operations involved in incrementing/decrementing the reference counter.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)