[GitHub] [superset] eschutho commented on a change in pull request #14237: [POC] feat: create text yml file for text overrides

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #14237:
URL: https://github.com/apache/superset/pull/14237#discussion_r620740880



##########
File path: superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
##########
@@ -298,11 +300,18 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
             <div className="helper">
               {t('Refer to the ')}
               <a
-                href={conf?.SQLALCHEMY_DOCS_URL ?? ''}
+                href={
+                  SQLALCHEMY_DOCS_URL ??
+                  'https://docs.sqlalchemy.org/en/13/core/engines.html'
+                }
                 target="_blank"
                 rel="noopener noreferrer"
               >
-                {conf?.SQLALCHEMY_DISPLAY_TEXT ?? ''}
+                {st(
+                  'DATABASE_MODAL.SQLALCHEMY_DISPLAY_TEXT',
+                  SQLALCHEMY_DISPLAY_TEXT,
+                  'SQLAlchemy docs',
+                )}

Review comment:
       if you wanted pybabel to pick this up for extraction, you could try add `st` as a keyword.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org