You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "valepakh (via GitHub)" <gi...@apache.org> on 2026/01/26 13:23:08 UTC

[PR] IGNITE-27539 Detect duplicate file names on case-insensitive file systems [ignite-3]

valepakh opened a new pull request, #7474:
URL: https://github.com/apache/ignite-3/pull/7474

   https://issues.apache.org/jira/browse/IGNITE-27539


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-27539 Detect duplicate file names on case-insensitive file systems [ignite-3]

Posted by "valepakh (via GitHub)" <gi...@apache.org>.
valepakh commented on code in PR #7474:
URL: https://github.com/apache/ignite-3/pull/7474#discussion_r2744991105


##########
modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/deployment/DeploymentManagementControllerTest.java:
##########
@@ -144,15 +148,11 @@ public void cleanup() {
     @Test
     public void testDeploySuccessful() {
         assertThat(deploy(UNIT_ID, VERSION), hasStatus(OK));
-
-        awaitDeployedStatus(UNIT_ID, VERSION);

Review Comment:
   > Why do remove it?
   
   It was needed only for the cleanup method to work, which was checking `DEPLOYED` status. Since I changed it to check `UPLOADING` as well, this wait is not needed anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-27539 Detect duplicate file names on case-insensitive file systems [ignite-3]

Posted by "Pochatkin (via GitHub)" <gi...@apache.org>.
Pochatkin commented on code in PR #7474:
URL: https://github.com/apache/ignite-3/pull/7474#discussion_r2741427928


##########
modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/deployment/DeploymentManagementControllerTest.java:
##########
@@ -144,15 +148,11 @@ public void cleanup() {
     @Test
     public void testDeploySuccessful() {
         assertThat(deploy(UNIT_ID, VERSION), hasStatus(OK));
-
-        awaitDeployedStatus(UNIT_ID, VERSION);

Review Comment:
   Why do remove it?



##########
modules/rest/src/main/java/org/apache/ignite/internal/rest/deployment/CompletedFileUploadSubscriber.java:
##########
@@ -76,18 +76,19 @@ public void onComplete() {
         if (ex != null) {
             result.completeExceptionally(ex);
         } else {
-            try {
-                DeploymentUnit deploymentUnit = collector.toDeploymentUnit();
-                result.complete(deploymentUnit);
-            } catch (Exception e) {
-                suppressException(e);
-                try {
-                    collector.rollback();
-                } catch (Exception e2) {
-                    suppressException(e2);
+            collector.toDeploymentUnit().whenComplete((deploymentUnit, throwable) -> {
+                if (throwable != null) {
+                    suppressException(throwable);
+                    try {
+                        collector.rollback();
+                    } catch (Exception e2) {
+                        suppressException(e2);
+                    }
+                    result.completeExceptionally(ex);

Review Comment:
   Should be `throwable` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-27539 Detect duplicate file names on case-insensitive file systems [ignite-3]

Posted by "valepakh (via GitHub)" <gi...@apache.org>.
valepakh commented on code in PR #7474:
URL: https://github.com/apache/ignite-3/pull/7474#discussion_r2744989013


##########
modules/rest/src/main/java/org/apache/ignite/internal/rest/deployment/CompletedFileUploadSubscriber.java:
##########
@@ -76,18 +76,19 @@ public void onComplete() {
         if (ex != null) {
             result.completeExceptionally(ex);
         } else {
-            try {
-                DeploymentUnit deploymentUnit = collector.toDeploymentUnit();
-                result.complete(deploymentUnit);
-            } catch (Exception e) {
-                suppressException(e);
-                try {
-                    collector.rollback();
-                } catch (Exception e2) {
-                    suppressException(e2);
+            collector.toDeploymentUnit().whenComplete((deploymentUnit, throwable) -> {
+                if (throwable != null) {
+                    suppressException(throwable);
+                    try {
+                        collector.rollback();
+                    } catch (Exception e2) {
+                        suppressException(e2);
+                    }
+                    result.completeExceptionally(ex);

Review Comment:
   We need to complete the future with the `ex`, which could already be non-null. We add `throwable` to the suppressed exceptions in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-27539 Detect duplicate file names on case-insensitive file systems [ignite-3]

Posted by "Pochatkin (via GitHub)" <gi...@apache.org>.
Pochatkin merged PR #7474:
URL: https://github.com/apache/ignite-3/pull/7474


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org