You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "bram de jong (JIRA)" <ji...@apache.org> on 2008/06/03 15:40:45 UTC
[jira] Created: (SOLR-589) DisMaxRequestHandler crashes on badly
formed query strings ( combinations of "-" and "+" )
DisMaxRequestHandler crashes on badly formed query strings ( combinations of "-" and "+" )
------------------------------------------------------------------------------------------
Key: SOLR-589
URL: https://issues.apache.org/jira/browse/SOLR-589
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.2
Environment: all platforms
Reporter: bram de jong
Priority: Minor
The DisMaxRequestHandler parser crashes on strings which contain double dashes or various combinations of - and + like:
chocolate cookie -
chocolate -+cookie
chocolate --cookie
chocolate - - cookie
Originally found by me:
http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
And verified by Sean Tim:
http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-589) DisMaxRequestHandler crashes on badly
formed query strings ( combinations of "-" and "+" )
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar updated SOLR-589:
---------------------------------------
Affects Version/s: 1.3
Fix Version/s: 1.3
Updating fix version to 1.3
> DisMaxRequestHandler crashes on badly formed query strings ( combinations of "-" and "+" )
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-589
> URL: https://issues.apache.org/jira/browse/SOLR-589
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.2, 1.3
> Environment: all platforms
> Reporter: bram de jong
> Assignee: Otis Gospodnetic
> Priority: Minor
> Fix For: 1.3
>
> Attachments: SOLR-589.patch, SOLR-589.patch, SOLR-589.patch
>
>
> The DisMaxRequestHandler parser crashes on strings which contain double dashes or various combinations of - and + like:
> chocolate cookie -
> chocolate -+cookie
> chocolate --cookie
> chocolate - - cookie
> Originally found by me:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
> And verified by Sean Tim:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-589) DisMaxRequestHandler crashes on badly
formed query strings ( combinations of "-" and "+" )
Posted by "Sean Timm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Timm updated SOLR-589:
---------------------------
Attachment: SOLR-589.patch
Simplified one of the regular expressions and improved performance for queries with a large number of sequential +/- operators. Added two additional test cases to test these scenarios.
> DisMaxRequestHandler crashes on badly formed query strings ( combinations of "-" and "+" )
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-589
> URL: https://issues.apache.org/jira/browse/SOLR-589
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.2
> Environment: all platforms
> Reporter: bram de jong
> Priority: Minor
> Attachments: SOLR-589.patch, SOLR-589.patch, SOLR-589.patch
>
>
> The DisMaxRequestHandler parser crashes on strings which contain double dashes or various combinations of - and + like:
> chocolate cookie -
> chocolate -+cookie
> chocolate --cookie
> chocolate - - cookie
> Originally found by me:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
> And verified by Sean Tim:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-589) DisMaxRequestHandler crashes on badly
formed query strings ( combinations of "-" and "+" )
Posted by "Sean Timm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Timm updated SOLR-589:
---------------------------
Attachment: SOLR-589.patch
Changed to use non-capturing groups. Also reversed the order the regular expressions are run. Both changes are for performance only.
> DisMaxRequestHandler crashes on badly formed query strings ( combinations of "-" and "+" )
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-589
> URL: https://issues.apache.org/jira/browse/SOLR-589
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.2
> Environment: all platforms
> Reporter: bram de jong
> Priority: Minor
> Attachments: SOLR-589.patch, SOLR-589.patch
>
>
> The DisMaxRequestHandler parser crashes on strings which contain double dashes or various combinations of - and + like:
> chocolate cookie -
> chocolate -+cookie
> chocolate --cookie
> chocolate - - cookie
> Originally found by me:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
> And verified by Sean Tim:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-589) DisMaxRequestHandler crashes on badly
formed query strings ( combinations of "-" and "+" )
Posted by "Sean Timm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Timm updated SOLR-589:
---------------------------
Attachment: SOLR-589.patch
This patch strips out consecutive +/- operators, or dangling +/- operators.
> DisMaxRequestHandler crashes on badly formed query strings ( combinations of "-" and "+" )
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-589
> URL: https://issues.apache.org/jira/browse/SOLR-589
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.2
> Environment: all platforms
> Reporter: bram de jong
> Priority: Minor
> Attachments: SOLR-589.patch
>
>
> The DisMaxRequestHandler parser crashes on strings which contain double dashes or various combinations of - and + like:
> chocolate cookie -
> chocolate -+cookie
> chocolate --cookie
> chocolate - - cookie
> Originally found by me:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
> And verified by Sean Tim:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-589) DisMaxRequestHandler crashes on badly
formed query strings ( combinations of "-" and "+" )
Posted by "Otis Gospodnetic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Otis Gospodnetic resolved SOLR-589.
-----------------------------------
Resolution: Fixed
Assignee: Otis Gospodnetic
Thanks Sean!
Sending CHANGES.txt
Sending src/java/org/apache/solr/search/DisMaxQParserPlugin.java
Sending src/java/org/apache/solr/util/SolrPluginUtils.java
Sending src/test/org/apache/solr/util/SolrPluginUtilsTest.java
Transmitting file data ....
Committed revision 686042.
> DisMaxRequestHandler crashes on badly formed query strings ( combinations of "-" and "+" )
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-589
> URL: https://issues.apache.org/jira/browse/SOLR-589
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.2
> Environment: all platforms
> Reporter: bram de jong
> Assignee: Otis Gospodnetic
> Priority: Minor
> Attachments: SOLR-589.patch, SOLR-589.patch, SOLR-589.patch
>
>
> The DisMaxRequestHandler parser crashes on strings which contain double dashes or various combinations of - and + like:
> chocolate cookie -
> chocolate -+cookie
> chocolate --cookie
> chocolate - - cookie
> Originally found by me:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
> And verified by Sean Tim:
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/200806.mbox/browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.