You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/03 04:08:07 UTC

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4117: add visitor for dal

tristaZero commented on issue #4117: add visitor for dal
URL: https://github.com/apache/incubator-shardingsphere/pull/4117#issuecomment-581228161
 
 
   Hi, @jingshanglu After reviewing your PR, i thought you are familiar with Sharding parser. Not only you consider to add some members for `some SQLStatement`, but make each `visitXX()` clear and in line with ss code standard. Good job!
   Some of my suggestions are attached, welcome your feedback.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services