[jira] [Commented] (TS-2036) Management update API for plugins doesn't work

["Nick Kew (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709194#comment-13709194 ] 

Nick Kew commented on TS-2036:
------------------------------

Aaargh!  "Provide patch" option just marks it as PatchAvailable, without offering the option to provide a patch.

git push is also eluding me with "error: no DAV locking support on https://git-wip-us.apache.org/repos/asf/trafficserver.git/", so here's the patch:

-#ifndef TS_NO_API
-    plugin_init(system_config_directory);        // plugin.config
-#else
+#ifdef TS_NO_API
     api_init();                 // we still need to initialize some of the data
     // i.e. http_global_hooks
+#else
+    plugin_init(system_config_directory);        // plugin.config
     pmgmt->registerPluginCallbacks(global_config_cbs);
 #endif

Summary: plugin callbacks need to be registered when there is an API, not when there isn't!  The patch switches #ifndef to #ifdef, because confusion over the double-negative is probably what caused the bug in the first place.
                
> Management update API for plugins doesn't work
> ----------------------------------------------
>
>                 Key: TS-2036
>                 URL: https://issues.apache.org/jira/browse/TS-2036
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Management API
>            Reporter: Nick Kew
>            Assignee: Nick Kew
>
> Functions registered with TSMgmtUpdateRegister are never called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira