You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by jacksontj <gi...@git.apache.org> on 2014/04/26 03:54:16 UTC
[GitHub] trafficserver pull request: Set the rpath when built "--with-opens...
GitHub user jacksontj opened a pull request:
https://github.com/apache/trafficserver/pull/75
Set the rpath when built "--with-openssl".
Thanks to @SaveTheRbtz for helping me figure out why my symbols where all messed up.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacksontj/trafficserver with-openssl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 53ecca477b2f1ea90fd9feb8bc264ec971bb6b8c
Author: Thomas Jackson <ja...@gmail.com>
Date: 2014-04-26T01:52:18Z
Set the rpath when built "--with-openssl".
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Set the rpath when built "--with-opens...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/75#issuecomment-41878736
This seems reasonable, especially since we used to do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Set the rpath when built "--with-opens...
Posted by SaveTheRbtz <gi...@git.apache.org>.
Github user SaveTheRbtz commented on the pull request:
https://github.com/apache/trafficserver/pull/75#issuecomment-41516411
@jpeach
The idea behind it is very simple: if user overrides path to openssl then he most likely wants to have that path added to `RPATH`, so when application is run it can actually find it, even if path is not in `ldconfig` or `LD_LIBRARY_PATH`/`LD_PRELOAD`.
PS. Note that it's the same behaviour as in 3.2.x:
https://github.com/apache/trafficserver/blob/3.2.x/build/crypto.m4#L93
PPS. And yes, probably it should be like that for all shared libraries: if path is overridden it should be added to `rpath`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Set the rpath when built "--with-opens...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/75#issuecomment-41553927
A long time ago, TS-562, we made some changes to (I think?) properly use -rpath with the libtool macros. See commit 449a4e4d83a6665a25371deca36b29ba7f4359df.
I don't know what has happened since then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Set the rpath when built "--with-opens...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/75#issuecomment-42855401
I was about to pull this, then I re-read @zwoop's comment about. @zwoop is correct; let's use a consistent autoconf syntax for this any apply is in all the places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Set the rpath when built "--with-opens...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Set the rpath when built "--with-opens...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/75#issuecomment-41513978
What is the problem you are solving here? I'm guessing that -R is the same as -Wl,-rpath, though I could not find it in the gcc options documentation. If we need to set rpath for OpenSSL, why not for other libraries? According to google, using rpath causes problems for distributions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---