You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/08/02 14:51:15 UTC
(commons-exec) branch master updated (7b32de54 -> 6a9780e8)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-exec.git
from 7b32de54 Bump org.apache.commons:commons-parent from 71 to 72 #204
new 6134d379 Replace OS.OS_* use of Locale.ENGLISH with Locale.ROOT
new 6a9780e8 Put 'type' before 'dev' in changes.xml
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/changes/changes.xml | 91 +++++++++++-----------
src/main/java/org/apache/commons/exec/OS.java | 6 +-
.../exec/environment/EnvironmentUtilsTest.java | 4 +-
3 files changed, 51 insertions(+), 50 deletions(-)
(commons-exec) 01/02: Replace OS.OS_* use of Locale.ENGLISH with Locale.ROOT
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-exec.git
commit 6134d379e2d7eb730aa9cf2e9e845ecdcb8f4a62
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Aug 2 10:49:33 2024 -0400
Replace OS.OS_* use of Locale.ENGLISH with Locale.ROOT
---
src/changes/changes.xml | 1 +
src/main/java/org/apache/commons/exec/OS.java | 6 +++---
.../org/apache/commons/exec/environment/EnvironmentUtilsTest.java | 4 ++--
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 2a30ae76..e0673de3 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -33,6 +33,7 @@
<action dev="ggregory" type="fix" due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in DefaultExecutor.</action>
<action dev="ggregory" type="fix" due-to="Gary Gregory">Fix PMD EmptyCatchBlock by allowing commented blocks.</action>
<action dev="ggregory" type="fix" due-to="Gary Gregory">Fix PMD EmptyControlStatement by allowing commented blocks.</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Replace OS.OS_* use of Locale.ENGLISH with Locale.ROOT.</action>
<!-- UPDATE -->
<action dev="ggregory" type="update" due-to="Dependabot, Gary Gregory">Bump org.apache.commons:commons-parent from 65 to 72 #174, #204.</action>
</release>
diff --git a/src/main/java/org/apache/commons/exec/OS.java b/src/main/java/org/apache/commons/exec/OS.java
index 36b14c72..3812a33b 100644
--- a/src/main/java/org/apache/commons/exec/OS.java
+++ b/src/main/java/org/apache/commons/exec/OS.java
@@ -77,9 +77,9 @@ public final class OS {
private static final String DARWIN = "darwin";
- private static final String OS_NAME = System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
- private static final String OS_ARCH = System.getProperty("os.arch").toLowerCase(Locale.ENGLISH);
- private static final String OS_VERSION = System.getProperty("os.version").toLowerCase(Locale.ENGLISH);
+ private static final String OS_NAME = System.getProperty("os.name").toLowerCase(Locale.ROOT);
+ private static final String OS_ARCH = System.getProperty("os.arch").toLowerCase(Locale.ROOT);
+ private static final String OS_VERSION = System.getProperty("os.version").toLowerCase(Locale.ROOT);
private static final String PATH_SEP = File.pathSeparator;
/**
diff --git a/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java b/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
index 5b6b883c..7241f91b 100644
--- a/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
+++ b/src/test/java/org/apache/commons/exec/environment/EnvironmentUtilsTest.java
@@ -89,8 +89,8 @@ public class EnvironmentUtilsTest {
for (final Entry<String, String> entry : procEnvironment.entrySet()) {
final String key = entry.getKey();
final String value = entry.getValue();
- assertEquals(value, procEnvironment.get(key.toLowerCase(Locale.ENGLISH)));
- assertEquals(value, procEnvironment.get(key.toUpperCase(Locale.ENGLISH)));
+ assertEquals(value, procEnvironment.get(key.toLowerCase(Locale.ROOT)));
+ assertEquals(value, procEnvironment.get(key.toUpperCase(Locale.ROOT)));
}
// add an environment variable and check access
(commons-exec) 02/02: Put 'type' before 'dev' in changes.xml
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-exec.git
commit 6a9780e80bb420e7f5a9d2573190324f335c296d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Aug 2 10:51:10 2024 -0400
Put 'type' before 'dev' in changes.xml
---
src/changes/changes.xml | 90 ++++++++++++++++++++++++-------------------------
1 file changed, 45 insertions(+), 45 deletions(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index e0673de3..bf7f9919 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -26,70 +26,70 @@
<body>
<release version="1.4.1" date="20YY-MM-DD" description="Maintenance and feature Release (Java 8 or above)">
<!-- ADD -->
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add Maven property project.build.outputTimestamp for build reproducibility.</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add Maven property project.build.outputTimestamp for build reproducibility.</action>
<!-- FIX -->
- <action dev="ggregory" type="fix" issue="EXEC-122" due-to="Marcono1234">Document PumpStreamHandler stream thread-safety requirements.</action>
- <action dev="ggregory" type="fix" due-to="Marcono1234">Fix CI only running on Ubuntu & improve OS-specific tests #143.</action>
- <action dev="ggregory" type="fix" due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in DefaultExecutor.</action>
- <action dev="ggregory" type="fix" due-to="Gary Gregory">Fix PMD EmptyCatchBlock by allowing commented blocks.</action>
- <action dev="ggregory" type="fix" due-to="Gary Gregory">Fix PMD EmptyControlStatement by allowing commented blocks.</action>
+ <action type="fix" dev="ggregory" issue="EXEC-122" due-to="Marcono1234">Document PumpStreamHandler stream thread-safety requirements.</action>
+ <action type="fix" dev="ggregory" due-to="Marcono1234">Fix CI only running on Ubuntu & improve OS-specific tests #143.</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD UnnecessaryFullyQualifiedName in DefaultExecutor.</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD EmptyCatchBlock by allowing commented blocks.</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix PMD EmptyControlStatement by allowing commented blocks.</action>
<action type="fix" dev="ggregory" due-to="Gary Gregory">Replace OS.OS_* use of Locale.ENGLISH with Locale.ROOT.</action>
<!-- UPDATE -->
- <action dev="ggregory" type="update" due-to="Dependabot, Gary Gregory">Bump org.apache.commons:commons-parent from 65 to 72 #174, #204.</action>
+ <action type="update" dev="ggregory" due-to="Dependabot, Gary Gregory">Bump org.apache.commons:commons-parent from 65 to 72 #174, #204.</action>
</release>
<release version="1.4.0" date="2024-01-01" description="Maintenance and feature Release (Java 8 or above)">
<!-- ADD -->
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add ShutdownHookProcessDestroyer.isEmpty().</action>
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add DefaultExecuteResultHandler.waitFor(Duration).</action>
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add Watchdog.Watchdog(Duration).</action>
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add ExecuteWatchdog.ExecuteWatchdog(Duration).</action>
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add PumpStreamHandler.setStopTimeout(Duration) and deprecate PumpStreamHandler.setStopTimeout(long).</action>
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add DefaultExecutor.Builder.</action>
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add DaemonExecutor.Builder.</action>
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add ExecuteWatchdog.Builder.</action>
- <action dev="ggregory" type="add" due-to="Gary Gregory">Add Watchdog.Builder.</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add ShutdownHookProcessDestroyer.isEmpty().</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add DefaultExecuteResultHandler.waitFor(Duration).</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add Watchdog.Watchdog(Duration).</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add ExecuteWatchdog.ExecuteWatchdog(Duration).</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add PumpStreamHandler.setStopTimeout(Duration) and deprecate PumpStreamHandler.setStopTimeout(long).</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add DefaultExecutor.Builder.</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add DaemonExecutor.Builder.</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add ExecuteWatchdog.Builder.</action>
+ <action type="add" dev="ggregory" due-to="Gary Gregory">Add Watchdog.Builder.</action>
<!-- FIX -->
<action issue="EXEC-105" type="fix" due-to="Dimitrios Efthymiou">Fix code snippet in tutorial page.</action>
<action issue="EXEC-100" dev="sgoeschl" type="fix" date="2016-01-11">Sync org.apache.commons.exec.OS with the newest Ant source file.</action>
<action issue="EXEC-64" dev="sebb" type="fix" due-to="Michael Vorburger">DefaultExecutor swallows IOException cause instead of propagating it (work-round for Java 1.5).</action>
- <action dev="ggregory" type="fix" due-to="nullptr">Java-style Array declaration and remove empty finally block #26.</action>
- <action dev="ggregory" type="fix" due-to="John Patrick">Use JUnit 5 assertThrows() #72.</action>
- <action dev="ggregory" type="fix" due-to="step-security-bot, Gary Gregory">[StepSecurity] ci: Harden GitHub Actions #107.</action>
- <action dev="ggregory" type="fix" due-to="Gary Gregory">Port from JUnit 4 to 5.</action>
- <action dev="ggregory" type="fix" due-to="ArdenL-Liu, Gary Gregory">[Javadoc] CommandLine.toCleanExecutable(final String dirtyExecutable) IllegalArgumentException #61.</action>
- <action dev="ggregory" type="fix" due-to="Gary Gregory">ExecuteException propagates its cause to its IOException superclass.</action>
- <action dev="ggregory" type="fix" due-to="Gary Gregory">Propagate exception in DebugUtils.handleException(String, Exception).</action>
- <action dev="ggregory" type="fix" due-to="Gary Gregory">Deprecate StringUtils.toString(String[], String) in favor of String.join(CharSequence, CharSequence...).</action>
+ <action type="fix" dev="ggregory" due-to="nullptr">Java-style Array declaration and remove empty finally block #26.</action>
+ <action type="fix" dev="ggregory" due-to="John Patrick">Use JUnit 5 assertThrows() #72.</action>
+ <action type="fix" dev="ggregory" due-to="step-security-bot, Gary Gregory">[StepSecurity] ci: Harden GitHub Actions #107.</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Port from JUnit 4 to 5.</action>
+ <action type="fix" dev="ggregory" due-to="ArdenL-Liu, Gary Gregory">[Javadoc] CommandLine.toCleanExecutable(final String dirtyExecutable) IllegalArgumentException #61.</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">ExecuteException propagates its cause to its IOException superclass.</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Propagate exception in DebugUtils.handleException(String, Exception).</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate StringUtils.toString(String[], String) in favor of String.join(CharSequence, CharSequence...).</action>
<action issue="EXEC-78" dev="ggregory" type="fix">No need to use System.class.getMethod("getenv",...) any more.</action>
<action issue="EXEC-70" dev="ggregory" type="fix">Delegate thread creation to java.util.concurrent.ThreadFactory.</action>
- <action dev="ggregory" type="fix" due-to="Gary Gregory">Avoid NullPointerException in MapUtils.prefix(Map, String).</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">Avoid NullPointerException in MapUtils.prefix(Map, String).</action>
<!-- REMOVE -->
- <action dev="ggregory" type="remove" due-to="Gary Gregory">Deprecate DefaultExecuteResultHandler.waitFor(long).</action>
- <action dev="ggregory" type="remove" due-to="Gary Gregory">Deprecate ExecuteWatchdog.ExecuteWatchdog(long).</action>
- <action dev="ggregory" type="remove" due-to="Gary Gregory">Deprecate Watchdog.Watchdog(long).</action>
- <action dev="ggregory" type="remove" due-to="Gary Gregory">Drop obsolete and unmaintained Ant build.</action>
- <action dev="ggregory" type="remove" due-to="Gary Gregory">Drop CLIRR plugin, replaced by JApiCmp.</action>
+ <action type="remove" dev="ggregory" due-to="Gary Gregory">Deprecate DefaultExecuteResultHandler.waitFor(long).</action>
+ <action type="remove" dev="ggregory" due-to="Gary Gregory">Deprecate ExecuteWatchdog.ExecuteWatchdog(long).</action>
+ <action type="remove" dev="ggregory" due-to="Gary Gregory">Deprecate Watchdog.Watchdog(long).</action>
+ <action type="remove" dev="ggregory" due-to="Gary Gregory">Drop obsolete and unmaintained Ant build.</action>
+ <action type="remove" dev="ggregory" due-to="Gary Gregory">Drop CLIRR plugin, replaced by JApiCmp.</action>
<!-- UPDATE -->
- <action dev="ggregory" type="update" due-to="Gary Gregory, Dependabot">Bump github actions #52.</action>
- <action issue="EXEC-111" dev="ggregory" type="update" due-to="Gary Gregory">Update from Java 5 to 6.</action>
- <action dev="ggregory" type="update" due-to="Gary Gregory">Update from Java 7 to 8.</action>
- <action dev="ggregory" type="update" due-to="Gary Gregory">Bump actions/cache from 2 to 3.0.11 #48, #51, #55, #69.</action>
- <action dev="ggregory" type="update" due-to="Dependabot, Gary Gregory">Bump actions/checkout from 2.3.2 to 3.1.0 #24, #46, #68.</action>
- <action dev="ggregory" type="update" due-to="Dependabot, Gary Gregory">Bump actions/setup-java from 1.4.0 to 3.8.0 #21, #50, #70, #78.</action>
- <action dev="ggregory" type="update" due-to="Dependabot">Bump junit from 4.13 to 5.9.1 Vintage #23, #33.</action>
- <action dev="ggregory" type="update" due-to="Dependabot">Bump maven-pmd-plugin from 2.7.1 to 3.19.0 #45, #62.</action>
- <action dev="ggregory" type="update" due-to="Dependabot">Bump maven-checkstyle-plugin from 2.13 to 3.2.0 #29, #60.</action>
- <action dev="ggregory" type="update" due-to="Dependabot, Gary Gregory">Bump commons-parent from 52 to 65, #49, #65, #79, #88, #105, #137.</action>
- <action dev="ggregory" type="update" due-to="Gary Gregory">Bump japicmp-maven-plugin from 0.15.6 to 0.16.0.</action>
+ <action type="update" dev="ggregory" due-to="Gary Gregory, Dependabot">Bump github actions #52.</action>
+ <action issue="EXEC-111" type="update" dev="ggregory" due-to="Gary Gregory">Update from Java 5 to 6.</action>
+ <action type="update" dev="ggregory" due-to="Gary Gregory">Update from Java 7 to 8.</action>
+ <action type="update" dev="ggregory" due-to="Gary Gregory">Bump actions/cache from 2 to 3.0.11 #48, #51, #55, #69.</action>
+ <action type="update" dev="ggregory" due-to="Dependabot, Gary Gregory">Bump actions/checkout from 2.3.2 to 3.1.0 #24, #46, #68.</action>
+ <action type="update" dev="ggregory" due-to="Dependabot, Gary Gregory">Bump actions/setup-java from 1.4.0 to 3.8.0 #21, #50, #70, #78.</action>
+ <action type="update" dev="ggregory" due-to="Dependabot">Bump junit from 4.13 to 5.9.1 Vintage #23, #33.</action>
+ <action type="update" dev="ggregory" due-to="Dependabot">Bump maven-pmd-plugin from 2.7.1 to 3.19.0 #45, #62.</action>
+ <action type="update" dev="ggregory" due-to="Dependabot">Bump maven-checkstyle-plugin from 2.13 to 3.2.0 #29, #60.</action>
+ <action type="update" dev="ggregory" due-to="Dependabot, Gary Gregory">Bump commons-parent from 52 to 65, #49, #65, #79, #88, #105, #137.</action>
+ <action type="update" dev="ggregory" due-to="Gary Gregory">Bump japicmp-maven-plugin from 0.15.6 to 0.16.0.</action>
</release>
<release version="1.3" date="2014-11-02" description="Maintenance and feature Release">
- <action issue="EXEC-69" dev="ggregory" type="add" due-to="Richard Atkins, Michael Vorburger">
+ <action issue="EXEC-69" type="add" dev="ggregory" due-to="Richard Atkins, Michael Vorburger">
DefaultExecutor async execute prevents shutdown hooks running.
</action>
- <action issue="EXEC-81" dev="ggregory" type="fix" date="2014-02-04" due-to="Stephen Compall">
+ <action issue="EXEC-81" type="fix" dev="ggregory" date="2014-02-04" due-to="Stephen Compall">
Remove remaining raw types, unchecked conversions
</action>
- <action issue="EXEC-80" dev="ggregory" type="fix" date="2014-02-04">
+ <action issue="EXEC-80" type="fix" dev="ggregory" date="2014-02-04">
NullPointerException in EnvironmentUtils.toString(map)
</action>
<action issue="EXEC-78" dev="sebb" type="update" date="2014-01-11">
@@ -103,7 +103,7 @@
</action>
</release>
<release version="1.2" date="2014-01-02" description="Maintenance and small feature Release">
- <action issue="EXEC-68" dev="ggregory" type="fix" date="2012-10-22" due-to="Joel McCance">
+ <action issue="EXEC-68" type="fix" dev="ggregory" date="2012-10-22" due-to="Joel McCance">
Watchdog kills process immediately if timeout is too large.
</action>
<action issue="EXEC-57" dev="sgoeschl" type="fix" date="2011-10-10" due-to="Nickolay Martinov">