[jira] [Commented] (BEAM-10448) Java + Universal Local Runner: custom WindowFn support seems incomplete

["Robert Bradshaw (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155777#comment-17155777 ] 

Robert Bradshaw commented on BEAM-10448:
----------------------------------------

I'm looking at testNonPartitioningWindowing and trying to understand why the correct output should not be

{{
            output("a", 1, 1, -5, 5),
            output("a", 2, 1, 0, 10),
            output("a", 1, 7, 5, 15),
            output("b", 1, 8, 0, 10),
            output("b", 1, 8, 5, 15));
}}

instead of 

https://github.com/apache/beam/blob/release-2.22.0/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowingTest.java#L144

> Java + Universal Local Runner: custom WindowFn support seems incomplete
> -----------------------------------------------------------------------
>
>                 Key: BEAM-10448
>                 URL: https://issues.apache.org/jira/browse/BEAM-10448
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-universal, sdk-java-core, sdk-java-harness
>            Reporter: Kenneth Knowles
>            Priority: P2
>
> On https://github.com/apache/beam/pull/11792/ the following tests failed and were sickbayed:
> {code}
>      excludeTestsMatching 'org.apache.beam.sdk.transforms.windowing.WindowTest.testMergingCustomWindows'
>     excludeTestsMatching 'org.apache.beam.sdk.transforms.windowing.WindowTest.testMergingCustomWindowsKeyedCollection'
>     excludeTestsMatching 'org.apache.beam.sdk.transforms.windowing.WindowingTest.testMergingWindowing'
>     excludeTestsMatching 'org.apache.beam.sdk.transforms.windowing.WindowingTest.testNonPartitioningWindowing'
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)